Automated lint fixes

Signed-off-by: Juan Antonio Osorio <[email protected]>

Author: JAORMX

cmd/update-tools/main.go

@@ -84,7 +84,7 @@ func runUpdate(_ *cobra.Command, args []string) error {
 	newTools, err := fetchToolsFromMCP(serverName)
 	if err != nil {
 		logger.Warnf("Failed to fetch tools from MCP server: %v", err)
-		
+
 		if len(currentTools) > 0 && addWarnings {
 			if !dryRun {
 				if err := toolhive.AddWarningComment(specPath, "Tool list fetch failed", "Manual verification may be required"); err != nil {
@@ -103,7 +103,7 @@ func runUpdate(_ *cobra.Command, args []string) error {
 	if len(newTools) == 0 && len(currentTools) > 0 {
 		logger.Warnf("No tools detected but spec file had %d tools previously", len(currentTools))
 		logger.Info("Keeping existing tools list")
-		
+
 		if addWarnings {
 			if !dryRun {
 				if err := toolhive.AddWarningComment(specPath, "Tool list could not be auto-updated", "Please verify the tools list manually"); err != nil {
@@ -209,40 +209,40 @@ func showDetailedDiff(current, new []string) {
 func showSummaryDiff(current, new []string) {
 	currentSet := make(map[string]bool)
 	newSet := make(map[string]bool)
-	
+
 	for _, t := range current {
 		currentSet[t] = true
 	}
 	for _, t := range new {
 		newSet[t] = true
 	}
-	
+
 	// Find added tools
 	var added []string
 	for t := range newSet {
 		if !currentSet[t] {
 			added = append(added, t)
 		}
 	}
-	
+
 	// Find removed tools
 	var removed []string
 	for t := range currentSet {
 		if !newSet[t] {
 			removed = append(removed, t)
 		}
 	}
-	
+
 	sort.Strings(added)
 	sort.Strings(removed)
-	
+
 	if len(added) > 0 {
 		logger.Infof("  Added tools (%d):", len(added))
 		for _, t := range added {
 			logger.Infof("    + %s", t)
 		}
 	}
-	
+
 	if len(removed) > 0 {
 		logger.Infof("  Removed tools (%d):", len(removed))
 		for _, t := range removed {

pkg/toolhive/builder.go

@@ -57,11 +57,11 @@ func (b *CommandBuilder) Build() []string {
 func BuildRunCommand(spec *types.RegistryEntry, tempName, image string) []string {
 	builder := NewCommandBuilder("run")
 	builder.AddFlag("--name", tempName)
-	
+
 	if spec.ImageMetadata != nil {
 		// Add transport
 		builder.AddFlag("--transport", spec.ImageMetadata.Transport)
-		
+
 		// Add environment variables
 		if spec.ImageMetadata.EnvVars != nil {
 			for _, envVar := range spec.ImageMetadata.EnvVars {
@@ -75,15 +75,15 @@ func BuildRunCommand(spec *types.RegistryEntry, tempName, image string) []string
 				}
 			}
 		}
-		
+
 		// Add permission profile
-		if spec.ImageMetadata.Permissions != nil && spec.ImageMetadata.Permissions.Network != nil {
+		if spec.Permissions != nil && spec.Permissions.Network != nil {
 			builder.AddFlag("--permission-profile", "network")
 		}
 	}
-	
+
 	// Add the image as the last positional argument
 	builder.AddPositional(image)
-	
+
 	return builder.Build()
-}
+}

pkg/toolhive/client.go

@@ -8,6 +8,7 @@ import (
 	"time"
 
 	"github.com/stacklok/toolhive/pkg/logger"
+
 	"github.com/stacklok/toolhive-registry/pkg/types"
 )
 
@@ -27,7 +28,7 @@ func NewClient(thvPath string, verbose bool) (*Client, error) {
 			return nil, fmt.Errorf("thv binary not found in PATH: %w", err)
 		}
 	}
-	
+
 	return &Client{
 		thvPath: thvPath,
 		verbose: verbose,
@@ -58,11 +59,11 @@ func (c *Client) RunServer(spec *types.RegistryEntry, serverName string) (string
 	// Build the run command
 	tempName := fmt.Sprintf("temp-%s-%d", serverName, time.Now().Unix())
 	runArgs := BuildRunCommand(spec, tempName, image)
-	
+
 	if c.verbose {
 		logger.Debugf("Running command: thv %s", strings.Join(runArgs, " "))
 	}
-	
+
 	runCmd := exec.Command(c.thvPath, runArgs...)
 	runOutput, err := runCmd.CombinedOutput()
 	if err != nil {
@@ -71,7 +72,7 @@ func (c *Client) RunServer(spec *types.RegistryEntry, serverName string) (string
 
 	// Give the server time to start
 	time.Sleep(5 * time.Second)
-	
+
 	return tempName, nil
 }
 
@@ -83,7 +84,7 @@ func (c *Client) ListTools(serverName string) ([]string, error) {
 		AddFlag("--server", serverName).
 		AddFlag("--format", "json").
 		Build()
-	
+
 	listCmd := exec.Command(c.thvPath, listArgs...)
 	output, err := listCmd.CombinedOutput()
 	if err != nil {

pkg/toolhive/parser.go

@@ -32,22 +32,22 @@ func ParseToolsJSON(output string) ([]string, error) {
 		return ParseToolsText(output)
 	}
 	jsonOutput := output[jsonStart:]
-	
+
 	var result MCPListOutput
 	if err := json.Unmarshal([]byte(jsonOutput), &result); err != nil {
 		logger.Debugf("Failed to parse JSON output: %v", err)
 		// Fallback to text parsing
 		return ParseToolsText(output)
 	}
-	
+
 	var tools []string
 	for _, tool := range result.Tools {
 		tools = append(tools, tool.Name)
 	}
-	
+
 	// Sort tools alphabetically
 	sort.Strings(tools)
-	
+
 	return tools, nil
 }
 
@@ -60,19 +60,19 @@ func ParseToolsText(output string) ([]string, error) {
 	scanner := bufio.NewScanner(strings.NewReader(output))
 	for scanner.Scan() {
 		line := scanner.Text()
-		
+
 		// Look for TOOLS: section
 		if strings.HasPrefix(line, "TOOLS:") {
 			foundToolsSection = true
 			continue
 		}
-		
+
 		// Skip the NAME/DESCRIPTION header
 		if foundToolsSection && strings.HasPrefix(line, "NAME") {
 			foundHeader = true
 			continue
 		}
-		
+
 		// Extract tool names (first column)
 		if foundToolsSection && foundHeader && len(line) > 0 {
 			// Split by whitespace and get the first field
@@ -89,6 +89,6 @@ func ParseToolsText(output string) ([]string, error) {
 
 	// Sort tools alphabetically
 	sort.Strings(tools)
-	
+
 	return tools, nil
-}
+}

pkg/toolhive/spec.go

@@ -65,7 +65,7 @@ func updateToolsInNode(node *yaml.Node, tools []string) error {
 		Kind:    yaml.SequenceNode,
 		Content: make([]*yaml.Node, 0, len(tools)),
 	}
-	
+
 	for _, tool := range tools {
 		toolsNode.Content = append(toolsNode.Content, &yaml.Node{
 			Kind:  yaml.ScalarNode,
@@ -105,14 +105,14 @@ func AddWarningComment(path, warning, detail string) error {
 	lines := bytes.Split(data, []byte("\n"))
 	var output bytes.Buffer
 	warningAdded := false
-	
+
 	for i, line := range lines {
 		// Write existing line
 		if i > 0 {
 			output.WriteByte('\n')
 		}
 		output.Write(line)
-		
+
 		// Add warning after initial comments but before content
 		if !warningAdded && !bytes.HasPrefix(bytes.TrimSpace(line), []byte("#")) && len(bytes.TrimSpace(line)) > 0 {
 			// Insert warning before this line
@@ -127,11 +127,11 @@ func AddWarningComment(path, warning, detail string) error {
 				}
 				output.WriteByte('\n')
 			}
-			
+
 			// Add warning
 			output.WriteString(fmt.Sprintf("# WARNING: %s on %s\n", warning, time.Now().Format("2006-01-02")))
 			output.WriteString(fmt.Sprintf("# %s\n", detail))
-			
+
 			// Write current line
 			output.Write(line)
 			warningAdded = true
@@ -140,4 +140,4 @@ func AddWarningComment(path, warning, detail string) error {
 
 	// Write back to file
 	return os.WriteFile(path, output.Bytes(), 0644)
-}
+}