fix: polish some of the user-facing strings (#584)

* fix: polish some of the user-facing strings

* Update system tray strings

Author: danbarr

main/src/system-tray.ts

@@ -164,21 +164,21 @@ const startOnLoginMenu = (currentTray: Tray, toolHiveIsRunning: boolean) => {
 }
 
 const createShowMenuItem = () => ({
-  label: 'Show App',
+  label: 'Show Window',
   accelerator: 'CmdOrCtrl+S',
   type: 'normal' as const,
   click: withWindow(showWindowWithFocus),
 })
 
 const createHideMenuItem = () => ({
-  label: 'Hide App',
+  label: 'Hide Window',
   accelerator: 'CmdOrCtrl+H',
   type: 'normal' as const,
   click: withWindow(hideWindow),
 })
 
 const createQuitMenuItem = () => ({
-  label: 'Quit App',
+  label: 'Quit ToolHive',
   accelerator: 'CmdOrCtrl+Q',
   type: 'normal' as const,
   click: () => {

renderer/src/common/components/error/keyring-error.tsx

@@ -9,7 +9,7 @@ export function KeyringError() {
     >
       <p>
         ToolHive needs to access your system keyring in order to securely store
-        and manage your secrets.
+        and manage secrets.
       </p>
 
       <p>Most Linux distributions have a system keyring out of the box.</p>
@@ -23,7 +23,7 @@ export function KeyringError() {
           (should be automatically unlocked after logging in)
         </li>
         <li>
-          You have rebooted your computer after any changes to your keyring
+          You have rebooted your computer after any changes to the keyring
           configuration
         </li>
       </ul>

renderer/src/common/hooks/use-auto-launch.ts

@@ -19,7 +19,7 @@ export function useSetAutoLaunch() {
     },
     successMsg: (enabled) =>
       enabled
-        ? 'Auto-launch enabled - ToolHive will start with your system'
+        ? 'Auto-launch enabled - ToolHive will start when you log into your system'
         : 'Auto-launch disabled',
     errorMsg: 'Failed to update auto-launch setting',
   })

renderer/src/common/hooks/use-confirm-quit.ts

@@ -3,17 +3,14 @@ import { useConfirm } from './use-confirm'
 export function useConfirmQuit() {
   const confirm = useConfirm()
   return async () => {
-    return confirm(
-      'Shutting down ToolHive will also shut down all your MCP servers.',
-      {
-        title: 'Quitting will shut MCPs down',
-        isDestructive: true,
-        buttons: { yes: 'Quit', no: 'Cancel' },
-        doNotShowAgain: {
-          label: "Don't ask me again when quitting",
-          id: 'confirm_quit',
-        },
-      }
-    )
+    return confirm('Shutting down ToolHive stops all MCP servers.', {
+      title: 'Quit ToolHive',
+      isDestructive: true,
+      buttons: { yes: 'Quit', no: 'Cancel' },
+      doNotShowAgain: {
+        label: "Don't ask me again",
+        id: 'confirm_quit',
+      },
+    })
   }
 }

renderer/src/features/registry-servers/components/__tests__/form-run-from-registry.test.tsx

@@ -533,7 +533,7 @@ describe('FormRunFromRegistry', () => {
     })
     expect(
       screen.getByText(
-        'We are pulling the server image from the registry and installing it.'
+        'Downloading server image from the registry and installing.'
       )
     ).toBeInTheDocument()
   })
@@ -647,7 +647,7 @@ describe('FormRunFromRegistry', () => {
       expect(screen.getByText('Something went wrong')).toBeInTheDocument()
     })
     expect(
-      screen.getByText(/We were unable to create the secrets for the server/)
+      screen.getByText(/Failed to create secrets for the server/)
     ).toBeInTheDocument()
   })
 

renderer/src/features/registry-servers/components/alert-error-form-submission.tsx

@@ -15,7 +15,7 @@ interface AlertErrorFormSubmissionProps {
 
 function getErrorTitle(error: string): string {
   if (error.includes('Failed to retrieve MCP server image')) {
-    return 'We were unable to download the server image'
+    return 'ToolHive could not download the server image'
   }
   return 'Something went wrong'
 }
@@ -42,10 +42,9 @@ export function AlertErrorFormSubmission({
       </AlertTitle>
       <AlertDescription>
         <p className="text-red-300">
-          {isErrorSecrets &&
-            'We were unable to create the secrets for the server. '}
-          Check the configuration and try to install again. <br />
-          If you continue to have issues, reach out to our team for help via{' '}
+          {isErrorSecrets && 'Failed to create secrets for the server. '}
+          Check the configuration and try again. <br />
+          If issues persist, contact the ToolHive team via{' '}
           <Button asChild variant="link" size="xs" className="text-sm">
             <a
               href="https://discord.gg/stacklok"

renderer/src/features/registry-servers/components/loading-state-alert.tsx

@@ -29,7 +29,7 @@ export function LoadingStateAlert({
         <AlertDescription>
           {isPendingSecrets && loadingSecrets
             ? loadingSecrets?.text
-            : 'We are pulling the server image from the registry and installing it.'}
+            : 'Downloading server image from the registry and installing.'}
           {isPendingSecrets && loadingSecrets && (
             <Progress
               value={

renderer/src/features/secrets/components/dialog-form-secret.tsx

@@ -90,7 +90,7 @@ export function DialogFormSecret({
           <DialogDescription className="sr-only">
             {secretKey
               ? 'Update the secret value below.'
-              : 'Enter a name and value for your new secret.'}
+              : 'Enter a name and value for the new secret.'}
           </DialogDescription>
         </DialogHeader>
 

renderer/src/routes/__tests__/clients.test.tsx

@@ -60,7 +60,7 @@ describe('Clients Route', () => {
       expect(screen.getByText('No clients detected')).toBeInTheDocument()
       expect(
         screen.getByText(
-          'Clients are tools that can connect to ToolHive. If your client is not detected, consult our documentation.'
+          'Clients are tools that can connect to ToolHive. If your client is not detected, consult the documentation.'
         )
       ).toBeInTheDocument()
     }

renderer/src/routes/__tests__/secrets.test.tsx

@@ -60,7 +60,7 @@ it('renders add secret dialog when clicking add secret button', async () => {
   const srDescription = Array.from(dialog.querySelectorAll('p,div,span')).find(
     (el) =>
       el.className.includes('sr-only') &&
-      el.textContent?.includes('Enter a name and value for your new secret.')
+      el.textContent?.includes('Enter a name and value for the new secret.')
   )
   expect(srDescription).toBeTruthy()
   const ariaDescribedBy = dialog.getAttribute('aria-describedby')