Adds the command to list groups (#1148)

Author: amirejaz

cmd/thv/app/group.go

@@ -2,6 +2,10 @@ package app
 
 import (
 	"fmt"
+	"os"
+	"sort"
+	"strings"
+	"text/tabwriter"
 
 	"github.com/spf13/cobra"
 
@@ -22,6 +26,13 @@ var groupCreateCmd = &cobra.Command{
 	RunE:  groupCreateCmdFunc,
 }
 
+var groupListCmd = &cobra.Command{
+	Use:   "list",
+	Short: "List all groups",
+	Long:  `List all logical groups of MCP servers.`,
+	RunE:  groupListCmdFunc,
+}
+
 func groupCreateCmdFunc(cmd *cobra.Command, args []string) error {
 	groupName := args[0]
 	ctx := cmd.Context()
@@ -39,6 +50,47 @@ func groupCreateCmdFunc(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
+func groupListCmdFunc(cmd *cobra.Command, _ []string) error {
+	ctx := cmd.Context()
+
+	manager, err := groups.NewManager()
+	if err != nil {
+		return fmt.Errorf("failed to create group manager: %w", err)
+	}
+
+	allGroups, err := manager.List(ctx)
+	if err != nil {
+		return fmt.Errorf("failed to list groups: %w", err)
+	}
+
+	// Sort groups alphanumerically by name (handles mixed characters, numbers, etc.)
+	sort.Slice(allGroups, func(i, j int) bool {
+		return strings.Compare(allGroups[i].Name, allGroups[j].Name) < 0
+	})
+
+	if len(allGroups) == 0 {
+		fmt.Println("No groups configured.")
+		return nil
+	}
+
+	// Create a tabwriter for table output
+	w := tabwriter.NewWriter(os.Stdout, 0, 0, 3, ' ', 0)
+	fmt.Fprintln(w, "NAME")
+
+	// Print group names in table format
+	for _, group := range allGroups {
+		fmt.Fprintf(w, "%s\n", group.Name)
+	}
+
+	// Flush the tabwriter
+	if err := w.Flush(); err != nil {
+		return fmt.Errorf("failed to flush tabwriter: %w", err)
+	}
+
+	return nil
+}
+
 func init() {
 	groupCmd.AddCommand(groupCreateCmd)
+	groupCmd.AddCommand(groupListCmd)
 }

cmd/thv/app/run.go

@@ -49,11 +49,11 @@ permission profile. Additional configuration can be provided via flags.`,
 	},
 }
 
-var runConfig RunFlags
+var runFlags RunFlags
 
 func init() {
 	// Add run flags
-	AddRunFlags(runCmd, &runConfig)
+	AddRunFlags(runCmd, &runFlags)
 
 	// This is used for the K8s operator which wraps the run command, but shouldn't be visible to users.
 	if err := runCmd.Flags().MarkHidden("k8s-pod-patch"); err != nil {
@@ -81,33 +81,33 @@ func runCmdFunc(cmd *cobra.Command, args []string) error {
 	debugMode, _ := cmd.Flags().GetBool("debug")
 
 	// Build the run configuration
-	runnerConfig, err := BuildRunnerConfig(ctx, &runConfig, serverOrImage, cmdArgs, debugMode, cmd)
+	runnerConfig, err := BuildRunnerConfig(ctx, &runFlags, serverOrImage, cmdArgs, debugMode, cmd)
 	if err != nil {
 		return err
 	}
 
-	if runConfig.Group != "" {
+	if runFlags.Group != "" {
 		groupManager, err := groups.NewManager()
 		if err != nil {
 			return fmt.Errorf("failed to create group manager: %v", err)
 		}
 
 		// Check if the workload is already in a group
-		group, err := groupManager.GetWorkloadGroup(ctx, runConfig.Name)
+		group, err := groupManager.GetWorkloadGroup(ctx, runFlags.Name)
 		if err != nil {
 			return fmt.Errorf("failed to get workload group: %v", err)
 		}
-		if group != nil && group.Name != runConfig.Group {
-			return fmt.Errorf("workload '%s' is already in group '%s'", runConfig.Name, group.Name)
+		if group != nil && group.Name != runFlags.Group {
+			return fmt.Errorf("workload '%s' is already in group '%s'", runFlags.Name, group.Name)
 		}
 
 		// Validate that the group specified exists
-		exists, err := groupManager.Exists(ctx, runConfig.Group)
+		exists, err := groupManager.Exists(ctx, runFlags.Group)
 		if err != nil {
 			return fmt.Errorf("failed to check if group exists: %v", err)
 		}
 		if !exists {
-			return fmt.Errorf("group '%s' does not exist", runConfig.Group)
+			return fmt.Errorf("group '%s' does not exist", runFlags.Group)
 		}
 	}
 
@@ -118,7 +118,7 @@ func runCmdFunc(cmd *cobra.Command, args []string) error {
 	}
 	workloadManager := workloads.NewManagerFromRuntime(rt)
 
-	if runConfig.Foreground {
+	if runFlags.Foreground {
 		err = workloadManager.RunWorkload(ctx, runnerConfig)
 	} else {
 		// Run the workload in detached mode