Skip to content

Commit 43ca52d

Browse files
authored
Address feedback about Windsurf change (#1214)
Based on internal feedback. * Use `windsurf-jetbrains` for consistency. * Print the windsurf options in the command help.
1 parent 9179827 commit 43ca52d

File tree

8 files changed

+28
-20
lines changed

8 files changed

+28
-20
lines changed

cmd/thv/app/client.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ Valid clients are:
4040
- cursor: Cursor editor
4141
- roo-code: Roo Code extension for VS Code
4242
- vscode: Visual Studio Code
43-
- vscode-insider: Visual Studio Code Insiders edition`,
43+
- vscode-insider: Visual Studio Code Insiders edition
44+
- windsurf: Windsurf IDE
45+
- windsurf-jetbrains: Windsurf for JetBrains IDEs`,
4446
Args: cobra.ExactArgs(1),
4547
RunE: clientRegisterCmdFunc,
4648
}
@@ -55,7 +57,9 @@ Valid clients are:
5557
- cursor: Cursor editor
5658
- roo-code: Roo Code extension for VS Code
5759
- vscode: Visual Studio Code
58-
- vscode-insider: Visual Studio Code Insiders edition`,
60+
- vscode-insider: Visual Studio Code Insiders edition
61+
- windsurf: Windsurf IDE
62+
- windsurf-jetbrains: Windsurf for JetBrains IDEs`,
5963
Args: cobra.ExactArgs(1),
6064
RunE: clientRemoveCmdFunc,
6165
}
@@ -148,12 +152,12 @@ func clientRegisterCmdFunc(cmd *cobra.Command, args []string) error {
148152

149153
// Validate the client type
150154
switch clientType {
151-
case "roo-code", "cline", "cursor", "claude-code", "vscode-insider", "vscode", "windsurf", "windsurf-intellij":
155+
case "roo-code", "cline", "cursor", "claude-code", "vscode-insider", "vscode", "windsurf", "windsurf-jetbrains":
152156
// Valid client type
153157
default:
154158
return fmt.Errorf(
155159
"invalid client type: %s (valid types: roo-code, cline, cursor, claude-code, vscode, "+
156-
"vscode-insider, windsurf, windsurf-intellij)",
160+
"vscode-insider, windsurf, windsurf-jetbrains)",
157161
clientType)
158162
}
159163

@@ -179,12 +183,12 @@ func clientRemoveCmdFunc(cmd *cobra.Command, args []string) error {
179183

180184
// Validate the client type
181185
switch clientType {
182-
case "roo-code", "cline", "cursor", "claude-code", "vscode-insider", "vscode", "windsurf", "windsurf-intellij":
186+
case "roo-code", "cline", "cursor", "claude-code", "vscode-insider", "vscode", "windsurf", "windsurf-jetbrains":
183187
// Valid client type
184188
default:
185189
return fmt.Errorf(
186190
"invalid client type: %s (valid types: roo-code, cline, cursor, claude-code, vscode, "+
187-
"vscode-insider, windsurf, windsurf-intellij)",
191+
"vscode-insider, windsurf, windsurf-jetbrains)",
188192
clientType)
189193
}
190194

docs/cli/thv_client_register.md

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/cli/thv_client_remove.md

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/server/docs.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/server/swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/server/swagger.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/config.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ const (
4040
ClaudeCode MCPClient = "claude-code"
4141
// Windsurf represents the Windsurf IDE.
4242
Windsurf MCPClient = "windsurf"
43-
// WindsurfIntelliJ represents the Windsurf plugin for IntelliJ.
44-
WindsurfIntelliJ MCPClient = "windsurf-intellij"
43+
// WindsurfJetBrains represents the Windsurf plugin for JetBrains.
44+
WindsurfJetBrains MCPClient = "windsurf-jetbrains"
4545
)
4646

4747
// Extension is extension of the client config file.
@@ -207,8 +207,8 @@ var supportedClientIntegrations = []mcpClientConfig{
207207
MCPServersUrlLabel: "serverUrl",
208208
},
209209
{
210-
ClientType: WindsurfIntelliJ,
211-
Description: "Windsurf plugin for IntelliJ",
210+
ClientType: WindsurfJetBrains,
211+
Description: "Windsurf plugin for JetBrains IDEs",
212212
SettingsFile: "mcp_config.json",
213213
MCPServersPathPrefix: "/mcpServers",
214214
RelPath: []string{".codeium"},

pkg/client/config_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,9 +315,9 @@ func TestSuccessfulClientConfigOperations(t *testing.T) {
315315
case Windsurf:
316316
assert.Contains(t, string(content), `"mcpServers":`,
317317
"Windsurf config should contain mcpServers key")
318-
case WindsurfIntelliJ:
318+
case WindsurfJetBrains:
319319
assert.Contains(t, string(content), `"mcpServers":`,
320-
"WindsurfIntelliJ config should contain mcpServers key")
320+
"WindsurfJetBrains config should contain mcpServers key")
321321
}
322322
}
323323
})
@@ -343,7 +343,7 @@ func TestSuccessfulClientConfigOperations(t *testing.T) {
343343
case VSCode, VSCodeInsider:
344344
assert.Contains(t, string(content), testURL,
345345
"VSCode config should contain the server URL")
346-
case Cursor, RooCode, ClaudeCode, Cline, Windsurf, WindsurfIntelliJ:
346+
case Cursor, RooCode, ClaudeCode, Cline, Windsurf, WindsurfJetBrains:
347347
assert.Contains(t, string(content), testURL,
348348
"Config should contain the server URL")
349349
}

0 commit comments

Comments
 (0)