do not check duplicate names when name is empty (#1440)

Co-authored-by: taskbot <[email protected]>

Author: yrobla

cmd/thv/app/run.go

@@ -149,12 +149,14 @@ func runCmdFunc(cmd *cobra.Command, args []string) error {
 		return fmt.Errorf("failed to create workload manager: %v", err)
 	}
 
-	exists, err := workloadManager.DoesWorkloadExist(ctx, runFlags.Name)
-	if err != nil {
-		return fmt.Errorf("failed to check if workload exists: %v", err)
-	}
-	if exists {
-		return fmt.Errorf("workload with name '%s' already exists", runFlags.Name)
+	if runFlags.Name != "" {
+		exists, err := workloadManager.DoesWorkloadExist(ctx, runFlags.Name)
+		if err != nil {
+			return fmt.Errorf("failed to check if workload exists: %v", err)
+		}
+		if exists {
+			return fmt.Errorf("workload with name '%s' already exists", runFlags.Name)
+		}
 	}
 	err = validateGroup(ctx, workloadManager, serverOrImage)
 	if err != nil {

pkg/api/v1/workloads.go

@@ -276,14 +276,16 @@ func (s *WorkloadRoutes) createWorkload(w http.ResponseWriter, r *http.Request)
 	}
 
 	// check if the workload already exists
-	exists, err := s.workloadManager.DoesWorkloadExist(ctx, req.Name)
-	if err != nil {
-		http.Error(w, fmt.Sprintf("Failed to check if workload exists: %v", err), http.StatusInternalServerError)
-		return
-	}
-	if exists {
-		http.Error(w, fmt.Sprintf("Workload with name %s already exists", req.Name), http.StatusConflict)
-		return
+	if req.Name != "" {
+		exists, err := s.workloadManager.DoesWorkloadExist(ctx, req.Name)
+		if err != nil {
+			http.Error(w, fmt.Sprintf("Failed to check if workload exists: %v", err), http.StatusInternalServerError)
+			return
+		}
+		if exists {
+			http.Error(w, fmt.Sprintf("Workload with name %s already exists", req.Name), http.StatusConflict)
+			return
+		}
 	}
 
 	// NOTE: None of the k8s-related config logic is included here.