Make transparent proxy healthcheck configurable (#1138)

Author: JAORMX

cmd/thv/app/proxy.go

@@ -214,7 +214,7 @@ func proxyCmdFunc(cmd *cobra.Command, args []string) error {
 		port, proxyTargetURI)
 
 	// Create the transparent proxy with middlewares
-	proxy := transparent.NewTransparentProxy(proxyHost, port, serverName, proxyTargetURI, nil, middlewares...)
+	proxy := transparent.NewTransparentProxy(proxyHost, port, serverName, proxyTargetURI, nil, false, middlewares...)
 	if err := proxy.Start(ctx); err != nil {
 		return fmt.Errorf("failed to start proxy: %v", err)
 	}

pkg/transport/http.go

@@ -229,8 +229,9 @@ func (t *HTTPTransport) Start(ctx context.Context) error {
 	logger.Infof("Setting up transparent proxy to forward from host port %d to %s",
 		t.proxyPort, targetURI)
 
-	// Create the transparent proxy with middlewares
-	t.proxy = transparent.NewTransparentProxy(t.host, t.proxyPort, t.containerName, targetURI, t.prometheusHandler, t.middlewares...)
+	// Create the transparent proxy with middlewares (enable healthcheck for MCP servers)
+	t.proxy = transparent.NewTransparentProxy(
+		t.host, t.proxyPort, t.containerName, targetURI, t.prometheusHandler, true, t.middlewares...)
 	if err := t.proxy.Start(ctx); err != nil {
 		return err
 	}

pkg/transport/proxy/transparent/transparent_proxy.go

@@ -70,6 +70,7 @@ func NewTransparentProxy(
 	containerName string,
 	targetURI string,
 	prometheusHandler http.Handler,
+	enableHealthCheck bool,
 	middlewares ...types.Middleware,
 ) *TransparentProxy {
 	proxy := &TransparentProxy{
@@ -83,9 +84,11 @@ func NewTransparentProxy(
 		sessionManager:    session.NewManager(30*time.Minute, session.NewProxySession),
 	}
 
-	// Create MCP pinger and health checker
-	mcpPinger := NewMCPPinger(targetURI)
-	proxy.healthChecker = healthcheck.NewHealthChecker("sse", mcpPinger)
+	// Create MCP pinger and health checker only if enabled
+	if enableHealthCheck {
+		mcpPinger := NewMCPPinger(targetURI)
+		proxy.healthChecker = healthcheck.NewHealthChecker("sse", mcpPinger)
+	}
 
 	return proxy
 }
@@ -273,8 +276,10 @@ func (p *TransparentProxy) Start(ctx context.Context) error {
 		finalHandler.ServeHTTP(w, r)
 	})
 
-	// Add health check endpoint (no middlewares)
-	mux.Handle("/health", p.healthChecker)
+	// Add health check endpoint (no middlewares) only if health checker is enabled
+	if p.healthChecker != nil {
+		mux.Handle("/health", p.healthChecker)
+	}
 
 	// Add Prometheus metrics endpoint if handler is provided (no middlewares)
 	if p.prometheusHandler != nil {
@@ -299,8 +304,10 @@ func (p *TransparentProxy) Start(ctx context.Context) error {
 		}
 	}()
 
-	// Start health-check monitoring
-	go p.monitorHealth(ctx)
+	// Start health-check monitoring only if health checker is enabled
+	if p.healthChecker != nil {
+		go p.monitorHealth(ctx)
+	}
 
 	return nil
 }

pkg/transport/proxy/transparent/transparent_test.go

@@ -20,7 +20,7 @@ func init() {
 
 func TestStreamingSessionIDDetection(t *testing.T) {
 	t.Parallel()
-	proxy := NewTransparentProxy("127.0.0.1", 0, "test", "http://example.com", nil)
+	proxy := NewTransparentProxy("127.0.0.1", 0, "test", "http://example.com", nil, true)
 	target := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.Header().Set("Content-Type", "text/event-stream; charset=utf-8")
 		w.WriteHeader(200)
@@ -77,7 +77,7 @@ func createBasicProxy(p *TransparentProxy, targetURL *url.URL) *httputil.Reverse
 func TestNoSessionIDInNonSSE(t *testing.T) {
 	t.Parallel()
 
-	p := NewTransparentProxy("127.0.0.1", 0, "test", "", nil)
+	p := NewTransparentProxy("127.0.0.1", 0, "test", "", nil, false)
 
 	target := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		// Set both content-type and also optionally MCP header to test behavior
@@ -102,7 +102,7 @@ func TestNoSessionIDInNonSSE(t *testing.T) {
 func TestHeaderBasedSessionInitialization(t *testing.T) {
 	t.Parallel()
 
-	p := NewTransparentProxy("127.0.0.1", 0, "test", "", nil)
+	p := NewTransparentProxy("127.0.0.1", 0, "test", "", nil, false)
 
 	target := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		// Set both content-type and also optionally MCP header to test behavior