Skip to content

Commit 81e6666

Browse files
authored
Update inspector to use upstream image (#2142)
Signed-off-by: Dan Barr <[email protected]> Co-authored-by: Dan Barr <[email protected]>
1 parent bca5e7a commit 81e6666

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

cmd/thv/app/inspector.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import (
1818
"github.com/stacklok/toolhive/pkg/labels"
1919
"github.com/stacklok/toolhive/pkg/logger"
2020
"github.com/stacklok/toolhive/pkg/permissions"
21-
"github.com/stacklok/toolhive/pkg/runner"
2221
"github.com/stacklok/toolhive/pkg/transport/types"
2322
"github.com/stacklok/toolhive/pkg/workloads"
2423
)
@@ -112,10 +111,11 @@ func inspectorCmdFunc(cmd *cobra.Command, args []string) error {
112111
}
113112

114113
imageManager := images.NewImageManager(ctx)
115-
processedImage, err := runner.HandleProtocolScheme(ctx, imageManager, inspector.Image, "")
114+
err = imageManager.PullImage(ctx, inspector.Image)
116115
if err != nil {
117-
return fmt.Errorf("failed to handle protocol scheme: %v", err)
116+
return fmt.Errorf("failed to pull inspector image: %v", err)
118117
}
118+
processedImage := inspector.Image
119119

120120
// Setup workload options with the required port configuration
121121
uiPortStr := strconv.Itoa(inspectorUIPort)

cmd/thv/app/inspector/version.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,5 @@ package inspector
33

44
// Image specifies the image to use for the inspector command.
55
// TODO: This could probably be a flag with a sensible default
6-
// TODO: Additionally, when the inspector image has been published
7-
// TODO: to docker.io, we can use that instead of npx
8-
// TODO: https://github.com/modelcontextprotocol/inspector/issues/237
9-
// Pinning to a specific version for stability. The latest version
10-
// as of 2025-07-09 broke the inspector command.
11-
var Image = "npx://@modelcontextprotocol/[email protected]"
6+
// Pinning to a specific version for stability.
7+
var Image = "ghcr.io/modelcontextprotocol/inspector:0.17.0"

0 commit comments

Comments
 (0)