issues/1449 - Enhance keyctl provider tests by enabling parallel execution for improved performance.

Author: Mauricio Bonetti

pkg/secrets/keyring/keyctl_linux.go

@@ -16,6 +16,8 @@ type keyctlProvider struct {
 	keys   map[string]map[string]int // service -> key -> keyid mapping
 }
 
+// NewKeyctlProvider creates a new keyring provider using Linux keyctl.
+// It initializes access to the user keyring for persistence across process invocations.
 func NewKeyctlProvider() (Provider, error) {
 	// Use user keyring for persistence across process invocations
 	ringID, err := unix.KeyctlGetKeyringID(unix.KEY_SPEC_USER_KEYRING, false)
@@ -138,6 +140,6 @@ func (k *keyctlProvider) IsAvailable() bool {
 	return true
 }
 
-func (k *keyctlProvider) Name() string {
+func (_ *keyctlProvider) Name() string {
 	return "Linux Keyctl"
 }

pkg/secrets/keyring/keyctl_linux_test.go

@@ -8,6 +8,7 @@ import (
 )
 
 func TestKeyctlProvider_Creation(t *testing.T) {
+	t.Parallel()
 	provider, err := NewKeyctlProvider()
 	if err != nil {
 		t.Skipf("Keyctl provider creation failed (may be expected in test environments): %v", err)
@@ -26,6 +27,7 @@ func TestKeyctlProvider_Creation(t *testing.T) {
 }
 
 func TestKeyctlProvider_Name(t *testing.T) {
+	t.Parallel()
 	provider, err := NewKeyctlProvider()
 	if err != nil {
 		t.Skipf("Keyctl provider creation failed: %v", err)
@@ -39,6 +41,7 @@ func TestKeyctlProvider_Name(t *testing.T) {
 }
 
 func TestKeyctlProvider_BasicOperations(t *testing.T) {
+	t.Parallel()
 	provider, err := NewKeyctlProvider()
 	if err != nil {
 		t.Skipf("Keyctl provider creation failed: %v", err)
@@ -55,6 +58,7 @@ func TestKeyctlProvider_BasicOperations(t *testing.T) {
 	testValue := "test-value"
 
 	t.Run("Set and Get", func(t *testing.T) {
+		t.Parallel()
 		// Set a value
 		err := provider.Set(testService, testKey, testValue)
 		if err != nil {
@@ -73,6 +77,7 @@ func TestKeyctlProvider_BasicOperations(t *testing.T) {
 	})
 
 	t.Run("Get_NotFound", func(t *testing.T) {
+		t.Parallel()
 		_, err := provider.Get("nonexistent-service", "nonexistent-key")
 		if err == nil {
 			t.Error("expected error for nonexistent key")
@@ -84,6 +89,7 @@ func TestKeyctlProvider_BasicOperations(t *testing.T) {
 	})
 
 	t.Run("Delete", func(t *testing.T) {
+		t.Parallel()
 		// Delete the test key
 		err := provider.Delete(testService, testKey)
 		if err != nil {
@@ -124,6 +130,7 @@ func TestKeyctlProvider_BasicOperations(t *testing.T) {
 }
 
 func TestKeyctlProvider_MultipleServices(t *testing.T) {
+	t.Parallel()
 	provider, err := NewKeyctlProvider()
 	if err != nil {
 		t.Skipf("Keyctl provider creation failed: %v", err)