Skip to content

Commit 9f001fc

Browse files
authored
Fix description of the --otel-insecure flag (#1120)
1 parent 13fdbe2 commit 9f001fc

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

cmd/thv-proxyrunner/app/run.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ func init() {
174174
runCmd.Flags().StringArrayVar(&runOtelHeaders, "otel-headers", nil,
175175
"OpenTelemetry OTLP headers in key=value format (e.g., x-honeycomb-team=your-api-key)")
176176
runCmd.Flags().BoolVar(&runOtelInsecure, "otel-insecure", false,
177-
"Disable TLS verification for OpenTelemetry endpoint")
177+
"Connect to the OpenTelemetry endpoint using HTTP instead of HTTPS")
178178
runCmd.Flags().BoolVar(&runOtelEnablePrometheusMetricsPath, "otel-enable-prometheus-metrics-path", false,
179179
"Enable Prometheus-style /metrics endpoint on the main transport port")
180180
runCmd.Flags().BoolVar(&runIsolateNetwork, "isolate-network", false,

cmd/thv/app/run.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ func init() {
218218
runCmd.Flags().StringArrayVar(&runOtelHeaders, "otel-headers", nil,
219219
"OpenTelemetry OTLP headers in key=value format (e.g., x-honeycomb-team=your-api-key)")
220220
runCmd.Flags().BoolVar(&runOtelInsecure, "otel-insecure", false,
221-
"Disable TLS verification for OpenTelemetry endpoint")
221+
"Connect to the OpenTelemetry endpoint using HTTP instead of HTTPS")
222222
runCmd.Flags().BoolVar(&runOtelEnablePrometheusMetricsPath, "otel-enable-prometheus-metrics-path", false,
223223
"Enable Prometheus-style /metrics endpoint on the main transport port")
224224
runCmd.Flags().StringArrayVar(&runOtelEnvironmentVariables, "otel-env-vars", nil,

docs/cli/thv_run.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/observability.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ thv run \
7373
| `--otel-service-name` | Service name for telemetry | `toolhive-mcp-proxy` |
7474
| `--otel-sampling-rate` | Trace sampling rate (0.0-1.0) | `0.1` (10%) |
7575
| `--otel-headers` | Authentication headers (key=value format) | None |
76-
| `--otel-insecure` | Disable TLS verification | `false` |
76+
| `--otel-insecure` | Connect using HTTP instead of HTTPS | `false` |
7777
| `--otel-enable-prometheus-metrics-path` | Enable Prometheus `/metrics` endpoint on main transport port | `false` (disabled) |
7878
| `--otel-env-vars` | Environment variable names to include as span attributes (comma-separated) | None |
7979

@@ -497,7 +497,6 @@ Control trace volume and costs with sampling:
497497
- Verify OTLP endpoint URL and authentication headers
498498
- Check network connectivity to the endpoint
499499
- Ensure sampling rate is not too low
500-
- Verify TLS configuration with `--otel-insecure` for testing
501500

502501
**Prometheus metrics not available**:
503502
- Confirm `--otel-enable-prometheus-metrics-path` is set

pkg/telemetry/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type Config struct {
4545
// Headers contains authentication headers for the OTLP endpoint
4646
Headers map[string]string
4747

48-
// Insecure indicates whether to disable TLS verification
48+
// Insecure indicates whether to use HTTP instead of HTTPS for the OTLP endpoint
4949
Insecure bool
5050

5151
// EnablePrometheusMetricsPath controls whether to expose Prometheus-style /metrics endpoint

0 commit comments

Comments
 (0)