Fix PodTemplateSpec validation condition persistence

The issue was that PodTemplateSpec validation was happening early and
setting the PodTemplateValid condition, but then image validation was
also setting the ImageValidated condition without persisting it to
status. This caused the ImageValidated condition to overwrite the
PodTemplateValid condition in subsequent status updates.

The fix ensures that both validation conditions are persisted
immediately after being set:
- PodTemplateSpec validation updates status after setting condition
- Image validation now also updates status after setting condition

This ensures both conditions are present in the MCPServer status and
the invalid-podtemplatespec e2e test will pass.

Signed-off-by: Juan Antonio Osorio <[email protected]>

Author: JAORMX

cmd/thv-operator/controllers/mcpserver_controller.go

@@ -217,6 +217,10 @@ func (r *MCPServerReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 		setImageValidationCondition(mcpServer, metav1.ConditionTrue,
 			mcpv1alpha1.ConditionReasonImageValidationSkipped,
 			"Image validation was not performed (no enforcement configured)")
+		// Update status to persist the condition
+		if statusErr := r.Status().Update(ctx, mcpServer); statusErr != nil {
+			ctxLogger.Error(statusErr, "Failed to update MCPServer status after image validation")
+		}
 	} else if goerr.Is(err, validation.ErrImageInvalid) {
 		ctxLogger.Error(err, "MCPServer image validation failed", "image", mcpServer.Spec.Image)
 		// Update status to reflect validation failure
@@ -247,6 +251,10 @@ func (r *MCPServerReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 		setImageValidationCondition(mcpServer, metav1.ConditionTrue,
 			mcpv1alpha1.ConditionReasonImageValidationSuccess,
 			"Image validation passed - image found in enforced registries")
+		// Update status to persist the condition
+		if statusErr := r.Status().Update(ctx, mcpServer); statusErr != nil {
+			ctxLogger.Error(statusErr, "Failed to update MCPServer status after image validation")
+		}
 	}
 
 	// Check if the MCPServer instance is marked to be deleted