fixes client configuration issues with streamable http (#852)

Author: amirejaz

cmd/thv/app/config.go

@@ -274,7 +274,7 @@ func addRunningMCPsToClient(ctx context.Context, clientName string) error {
 		// Update each configuration file
 		for _, clientConfig := range filteredClientConfigs {
 			// Update the MCP server configuration with locking
-			if err := client.Upsert(clientConfig, name, url); err != nil {
+			if err := client.Upsert(clientConfig, name, url, transportType); err != nil {
 				logger.Warnf("Warning: Failed to update MCP server configuration in %s: %v", clientConfig.Path, err)
 				continue
 			}

pkg/client/config.go

@@ -48,13 +48,15 @@ const (
 
 // mcpClientConfig represents a configuration path for a supported MCP client.
 type mcpClientConfig struct {
-	ClientType           MCPClient
-	Description          string
-	RelPath              []string
-	SettingsFile         string
-	PlatformPrefix       map[string][]string
-	MCPServersPathPrefix string
-	Extension            Extension
+	ClientType                    MCPClient
+	Description                   string
+	RelPath                       []string
+	SettingsFile                  string
+	PlatformPrefix                map[string][]string
+	MCPServersPathPrefix          string
+	Extension                     Extension
+	SupportedTransportTypesMap    map[types.TransportType]string
+	IsTransportTypeFieldSupported bool
 }
 
 var supportedClientIntegrations = []mcpClientConfig{
@@ -72,6 +74,12 @@ var supportedClientIntegrations = []mcpClientConfig{
 		},
 		MCPServersPathPrefix: "/mcpServers",
 		Extension:            JSON,
+		SupportedTransportTypesMap: map[types.TransportType]string{
+			types.TransportTypeStdio:          "stdio",
+			types.TransportTypeSSE:            "sse",
+			types.TransportTypeStreamableHTTP: "http",
+		},
+		IsTransportTypeFieldSupported: true,
 	},
 	{
 		ClientType:   Cline,
@@ -87,6 +95,11 @@ var supportedClientIntegrations = []mcpClientConfig{
 		},
 		MCPServersPathPrefix: "/mcpServers",
 		Extension:            JSON,
+		SupportedTransportTypesMap: map[types.TransportType]string{
+			types.TransportTypeSSE:   "sse",
+			types.TransportTypeStdio: "stdio",
+		},
+		IsTransportTypeFieldSupported: false,
 	},
 	{
 		ClientType:   VSCodeInsider,
@@ -102,6 +115,12 @@ var supportedClientIntegrations = []mcpClientConfig{
 		},
 		MCPServersPathPrefix: "/mcp/servers",
 		Extension:            JSON,
+		SupportedTransportTypesMap: map[types.TransportType]string{
+			types.TransportTypeStdio:          "stdio",
+			types.TransportTypeSSE:            "sse",
+			types.TransportTypeStreamableHTTP: "http",
+		},
+		IsTransportTypeFieldSupported: true,
 	},
 	{
 		ClientType:   VSCode,
@@ -117,6 +136,12 @@ var supportedClientIntegrations = []mcpClientConfig{
 			"windows": {"AppData", "Roaming"},
 		},
 		Extension: JSON,
+		SupportedTransportTypesMap: map[types.TransportType]string{
+			types.TransportTypeStdio:          "stdio",
+			types.TransportTypeSSE:            "sse",
+			types.TransportTypeStreamableHTTP: "http",
+		},
+		IsTransportTypeFieldSupported: true,
 	},
 	{
 		ClientType:           Cursor,
@@ -125,6 +150,14 @@ var supportedClientIntegrations = []mcpClientConfig{
 		MCPServersPathPrefix: "/mcpServers",
 		RelPath:              []string{".cursor"},
 		Extension:            JSON,
+		SupportedTransportTypesMap: map[types.TransportType]string{
+			types.TransportTypeStdio:          "stdio",
+			types.TransportTypeSSE:            "sse",
+			types.TransportTypeStreamableHTTP: "http",
+		},
+		// Adding type field is not explicitly required though, Cursor auto-detects and is able to
+		// connect to both sse and streamable-http types
+		IsTransportTypeFieldSupported: true,
 	},
 	{
 		ClientType:           ClaudeCode,
@@ -133,6 +166,12 @@ var supportedClientIntegrations = []mcpClientConfig{
 		MCPServersPathPrefix: "/mcpServers",
 		RelPath:              []string{},
 		Extension:            JSON,
+		SupportedTransportTypesMap: map[types.TransportType]string{
+			types.TransportTypeStdio:          "stdio",
+			types.TransportTypeSSE:            "sse",
+			types.TransportTypeStreamableHTTP: "http",
+		},
+		IsTransportTypeFieldSupported: true,
 	},
 }
 
@@ -200,12 +239,18 @@ func FindClientConfigs() ([]ConfigFile, error) {
 // for a `type` field, but Cursor and others do not. This allows us to
 // build up more complex MCP server configurations for different clients
 // without leaking them into the CMD layer.
-func Upsert(cf ConfigFile, name string, url string) error {
-	if cf.ClientType == VSCode || cf.ClientType == VSCodeInsider || cf.ClientType == ClaudeCode {
-		return cf.ConfigUpdater.Upsert(name, MCPServer{Url: url, Type: "sse"})
+func Upsert(cf ConfigFile, name string, url string, transportType string) error {
+	for i := range supportedClientIntegrations {
+		if cf.ClientType != supportedClientIntegrations[i].ClientType {
+			continue
+		}
+		mappedTransportType, ok := supportedClientIntegrations[i].SupportedTransportTypesMap[types.TransportType(transportType)]
+		if supportedClientIntegrations[i].IsTransportTypeFieldSupported && ok {
+			return cf.ConfigUpdater.Upsert(name, MCPServer{Url: url, Type: mappedTransportType})
+		}
+		return cf.ConfigUpdater.Upsert(name, MCPServer{Url: url})
 	}
-
-	return cf.ConfigUpdater.Upsert(name, MCPServer{Url: url})
+	return nil
 }
 
 // GenerateMCPServerURL generates the URL for an MCP server

pkg/client/config_test.go

@@ -286,7 +286,7 @@ func TestSuccessfulClientConfigOperations(t *testing.T) {
 		testURL := "http://localhost:9999/sse#test-server"
 
 		for _, cf := range configs {
-			err := Upsert(cf, testServer, testURL)
+			err := Upsert(cf, testServer, testURL, types.TransportTypeSSE.String())
 			require.NoError(t, err, "Should be able to add MCP server to %s config", cf.ClientType)
 
 			// Read the file and verify the server was added

pkg/client/manager.go

@@ -138,7 +138,7 @@ func (m *defaultManager) addRunningMCPsToClient(ctx context.Context, clientType
 		url := GenerateMCPServerURL(transportType, transport.LocalhostIPv4, port, name)
 
 		// Update the MCP server configuration with locking
-		if err := Upsert(*clientConfig, name, url); err != nil {
+		if err := Upsert(*clientConfig, name, url, transportType); err != nil {
 			logger.Warnf("Warning: Failed to update MCP server configuration in %s: %v", clientConfig.Path, err)
 			continue
 		}

pkg/runner/runner.go

@@ -300,7 +300,7 @@ func updateClientConfigurations(containerName string, containerLabels map[string
 	for _, clientConfig := range clientConfigs {
 		logger.Infof("Updating client configuration: %s", clientConfig.Path)
 
-		if err := client.Upsert(clientConfig, containerName, url); err != nil {
+		if err := client.Upsert(clientConfig, containerName, url, transportType); err != nil {
 			fmt.Printf("Warning: Failed to update MCP server configuration in %s: %v\n", clientConfig.Path, err)
 			continue
 		}