Make it run on tvOS, prefer beberkas solution on merge

textSelection is being ignored on tvOS

Author: MiaKoring

Sources/SwiftCrossUI/Views/Modifiers/TextSelectionModifier.swift

@@ -1,5 +1,6 @@
 extension View {
     /// Set selectability of contained text.
+    /// ignored on tvOS
     public func textSelectionEnabled(_ isEnabled: Bool = true) -> some View {
         EnvironmentModifier(
             self,

Sources/UIKitBackend/UIKitBackend+Control.swift

@@ -170,34 +170,35 @@ final class TappableWidget: ContainerWidget {
     }
 }
 
-@available(tvOS, unavailable)
-final class HoverableWidget: ContainerWidget {
-    private var hoverGestureRecognizer: UIHoverGestureRecognizer?
-
-    var hoverChangesHandler: ((Bool) -> Void)? {
-        didSet {
-            if hoverChangesHandler != nil && hoverGestureRecognizer == nil {
-                let gestureRecognizer = UIHoverGestureRecognizer(
-                    target: self,
-                    action: #selector(hoveringChanged(_:)))
-                child.view.addGestureRecognizer(gestureRecognizer)
-                self.hoverGestureRecognizer = gestureRecognizer
-            } else if hoverChangesHandler == nil, let hoverGestureRecognizer {
-                child.view.removeGestureRecognizer(hoverGestureRecognizer)
-                self.hoverGestureRecognizer = nil
+#if !os(tvOS)
+    final class HoverableWidget: ContainerWidget {
+        private var hoverGestureRecognizer: UIHoverGestureRecognizer?
+
+        var hoverChangesHandler: ((Bool) -> Void)? {
+            didSet {
+                if hoverChangesHandler != nil && hoverGestureRecognizer == nil {
+                    let gestureRecognizer = UIHoverGestureRecognizer(
+                        target: self,
+                        action: #selector(hoveringChanged(_:)))
+                    child.view.addGestureRecognizer(gestureRecognizer)
+                    self.hoverGestureRecognizer = gestureRecognizer
+                } else if hoverChangesHandler == nil, let hoverGestureRecognizer {
+                    child.view.removeGestureRecognizer(hoverGestureRecognizer)
+                    self.hoverGestureRecognizer = nil
+                }
             }
         }
-    }
 
-    @objc
-    func hoveringChanged(_ recognizer: UIHoverGestureRecognizer) {
-        switch recognizer.state {
-            case .began: hoverChangesHandler?(true)
-            case .ended: hoverChangesHandler?(false)
-            default: break
+        @objc
+        func hoveringChanged(_ recognizer: UIHoverGestureRecognizer) {
+            switch recognizer.state {
+                case .began: hoverChangesHandler?(true)
+                case .ended: hoverChangesHandler?(false)
+                default: break
+            }
         }
     }
-}
+#endif
 @available(tvOS, unavailable)
 final class SliderWidget: WrapperWidget<UISlider> {
     var onChange: ((Double) -> Void)?
@@ -331,8 +332,10 @@ extension UIKitBackend {
         onChange: @escaping (String) -> Void
     ) {
         let textEditorWidget = textEditor as! TextEditorWidget
-
-        textEditorWidget.child.isEditable = environment.isEnabled
+        //remove on merge, replace with beberka's solution
+        #if !os(tvOS)
+            textEditorWidget.child.isEditable = environment.isEnabled
+        #endif
         textEditorWidget.child.font = environment.resolvedFont.uiFont
         textEditorWidget.child.textColor = UIColor(color: environment.suggestedForegroundColor)
         textEditorWidget.onChange = onChange
@@ -448,18 +451,20 @@ extension UIKitBackend {
         }
     }
 
-    public func createHoverTarget(wrapping child: Widget) -> Widget {
-        HoverableWidget(child: child)
-    }
+    #if !os(tvOS)
+        public func createHoverTarget(wrapping child: Widget) -> Widget {
+            HoverableWidget(child: child)
+        }
 
-    public func updateHoverTarget(
-        _ hoverTarget: any WidgetProtocol,
-        environment: EnvironmentValues,
-        action: @escaping (Bool) -> Void
-    ) {
-        let wrapper = hoverTarget as! HoverableWidget
-        wrapper.hoverChangesHandler = action
-    }
+        public func updateHoverTarget(
+            _ hoverTarget: any WidgetProtocol,
+            environment: EnvironmentValues,
+            action: @escaping (Bool) -> Void
+        ) {
+            let wrapper = hoverTarget as! HoverableWidget
+            wrapper.hoverChangesHandler = action
+        }
+    #endif
 
     #if os(iOS) || os(visionOS) || targetEnvironment(macCatalyst)
         public func createSlider() -> Widget {

Sources/UIKitBackend/UIKitBackend+Passive.swift

@@ -126,27 +126,32 @@ final class OptionallySelectableLabel: UILabel {
     }
 
     private func setupTextSelection() {
-        let longPress = UILongPressGestureRecognizer(target: self, action: #selector(didLongPress))
-        addGestureRecognizer(longPress)
-        isUserInteractionEnabled = true
+        #if !os(tvOS)
+            let longPress = UILongPressGestureRecognizer(
+                target: self, action: #selector(didLongPress))
+            addGestureRecognizer(longPress)
+            isUserInteractionEnabled = true
+        #endif
     }
 
     @objc private func didLongPress(_ gesture: UILongPressGestureRecognizer) {
-        guard
-            isSelectable,
-            gesture.state == .began,
-            let text = self.attributedText?.string,
-            !text.isEmpty
-        else {
-            return
-        }
-        window?.endEditing(true)
-        guard becomeFirstResponder() else { return }
-
-        let menu = UIMenuController.shared
-        if !menu.isMenuVisible {
-            menu.showMenu(from: self, rect: textRect())
-        }
+        #if !os(tvOS)
+            guard
+                isSelectable,
+                gesture.state == .began,
+                let text = self.attributedText?.string,
+                !text.isEmpty
+            else {
+                return
+            }
+            window?.endEditing(true)
+            guard becomeFirstResponder() else { return }
+
+            let menu = UIMenuController.shared
+            if !menu.isMenuVisible {
+                menu.showMenu(from: self, rect: textRect())
+            }
+        #endif
     }
 
     override func canPerformAction(_ action: Selector, withSender sender: Any?) -> Bool {
@@ -160,13 +165,17 @@ final class OptionallySelectableLabel: UILabel {
     }
 
     private func cancelSelection() {
-        let menu = UIMenuController.shared
-        menu.hideMenu(from: self)
+        #if !os(tvOS)
+            let menu = UIMenuController.shared
+            menu.hideMenu(from: self)
+        #endif
     }
 
     @objc override func copy(_ sender: Any?) {
-        cancelSelection()
-        let board = UIPasteboard.general
-        board.string = text
+        #if !os(tvOS)
+            cancelSelection()
+            let board = UIPasteboard.general
+            board.string = text
+        #endif
     }
 }

Sources/UIKitBackend/UIKitBackend+WebView.swift

@@ -1,43 +1,46 @@
 import SwiftCrossUI
-import WebKit
 
-extension UIKitBackend {
-    public func createWebView() -> Widget {
-        WebViewWidget()
-    }
+#if canImport(WebKit)
+    import WebKit
 
-    public func updateWebView(
-        _ webView: Widget,
-        environment: EnvironmentValues,
-        onNavigate: @escaping (URL) -> Void
-    ) {
-        let webView = webView as! WebViewWidget
-        webView.onNavigate = onNavigate
-    }
+    extension UIKitBackend {
+        public func createWebView() -> Widget {
+            WebViewWidget()
+        }
 
-    public func navigateWebView(_ webView: Widget, to url: URL) {
-        let webView = webView as! WebViewWidget
-        let request = URLRequest(url: url)
-        webView.child.load(request)
-    }
-}
+        public func updateWebView(
+            _ webView: Widget,
+            environment: EnvironmentValues,
+            onNavigate: @escaping (URL) -> Void
+        ) {
+            let webView = webView as! WebViewWidget
+            webView.onNavigate = onNavigate
+        }
 
-/// A wrapper for WKWebView. Acts as the web view's delegate as well.
-final class WebViewWidget: WrapperWidget<WKWebView>, WKNavigationDelegate {
-    var onNavigate: ((URL) -> Void)?
+        public func navigateWebView(_ webView: Widget, to url: URL) {
+            let webView = webView as! WebViewWidget
+            let request = URLRequest(url: url)
+            webView.child.load(request)
+        }
+    }
 
-    init() {
-        super.init(child: WKWebView())
+    /// A wrapper for WKWebView. Acts as the web view's delegate as well.
+    final class WebViewWidget: WrapperWidget<WKWebView>, WKNavigationDelegate {
+        var onNavigate: ((URL) -> Void)?
 
-        child.navigationDelegate = self
-    }
+        init() {
+            super.init(child: WKWebView())
 
-    func webView(_ webView: WKWebView, didCommit navigation: WKNavigation!) {
-        guard let url = webView.url else {
-            print("warning: Web view has no URL")
-            return
+            child.navigationDelegate = self
         }
 
-        onNavigate?(url)
+        func webView(_ webView: WKWebView, didCommit navigation: WKNavigation!) {
+            guard let url = webView.url else {
+                print("warning: Web view has no URL")
+                return
+            }
+
+            onNavigate?(url)
+        }
     }
-}
+#endif