Implement Menu in UIKitBackend

Author: bbrk24

Sources/SwiftCrossUI/Views/Menu.swift

@@ -1,11 +1,9 @@
-public struct Menu: TypeSafeView {
+public struct Menu {
     public var label: String
     public var items: [MenuItem]
 
     var buttonWidth: Int?
 
-    public var body = EmptyView()
-
     public init(_ label: String, @MenuItemsBuilder items: () -> [MenuItem]) {
         self.label = label
         self.items = items()
@@ -34,6 +32,11 @@ public struct Menu: TypeSafeView {
             }
         )
     }
+}
+
+@available(iOS 14, macCatalyst 14, tvOS 17, *)
+extension Menu: TypeSafeView {
+    public var body: EmptyView { return EmptyView() }
 
     func children<Backend: AppBackend>(
         backend: Backend,

Sources/UIKitBackend/UIKitBackend+Control.swift

@@ -2,7 +2,15 @@ import SwiftCrossUI
 import UIKit
 
 final class ButtonWidget: WrapperWidget<UIButton> {
-    var onTap: (() -> Void)?
+    private let event: UIControl.Event
+
+    var onTap: (() -> Void)? {
+        didSet {
+            if oldValue == nil {
+                child.addTarget(self, action: #selector(buttonTapped), for: event)
+            }
+        }
+    }
 
     @objc
     func buttonTapped() {
@@ -11,7 +19,6 @@ final class ButtonWidget: WrapperWidget<UIButton> {
 
     init() {
         let type: UIButton.ButtonType
-        let event: UIControl.Event
         #if os(tvOS)
             type = .system
             event = .primaryActionTriggered
@@ -20,7 +27,6 @@ final class ButtonWidget: WrapperWidget<UIButton> {
             event = .touchUpInside
         #endif
         super.init(child: UIButton(type: type))
-        child.addTarget(self, action: #selector(buttonTapped), for: event)
     }
 }
 
@@ -177,14 +183,11 @@ extension UIKitBackend {
         ButtonWidget()
     }
 
-    public func updateButton(
-        _ button: Widget,
-        label: String,
-        action: @escaping () -> Void,
+    func setButtonTitle(
+        _ buttonWidget: ButtonWidget,
+        _ label: String,
         environment: EnvironmentValues
     ) {
-        let buttonWidget = button as! ButtonWidget
-
         // tvOS's buttons change foreground color when focused. If we set an
         // attributed string for `.normal` we also have to set another for
         // `.focused` with a colour that's readable on a white background.
@@ -204,6 +207,17 @@ extension UIKitBackend {
                 for: .normal
             )
         #endif
+    }
+
+    public func updateButton(
+        _ button: Widget,
+        label: String,
+        action: @escaping () -> Void,
+        environment: EnvironmentValues
+    ) {
+        let buttonWidget = button as! ButtonWidget
+
+        setButtonTitle(buttonWidget, label, environment: environment)
 
         buttonWidget.onTap = action
     }

Sources/UIKitBackend/UIKitBackend+Menu.swift

@@ -0,0 +1,66 @@
+import SwiftCrossUI
+import UIKit
+
+extension UIKitBackend {
+    public final class Menu {
+        var uiMenu: UIMenu?
+    }
+
+    public func createPopoverMenu() -> Menu {
+        return Menu()
+    }
+
+    static func transformMenu(
+        content: ResolvedMenu,
+        label: String,
+        identifier: UIMenu.Identifier? = nil
+    ) -> UIMenu {
+        let children = content.items.map { (item) -> UIMenuElement in
+            switch item {
+                case let .button(label, action):
+                    if let action {
+                        UIAction(title: label) { _ in action() }
+                    } else {
+                        UIAction(title: label, attributes: .disabled) { _ in }
+                    }
+                case let .submenu(submenu):
+                    transformMenu(content: submenu.content, label: submenu.label)
+            }
+        }
+
+        return UIMenu(title: label, identifier: identifier, children: children)
+    }
+
+    public func updatePopoverMenu(
+        _ menu: Menu, content: ResolvedMenu, environment _: EnvironmentValues
+    ) {
+        menu.uiMenu = UIKitBackend.transformMenu(content: content, label: "")
+    }
+
+    public func updateButton(
+        _ button: Widget,
+        label: String,
+        menu: Menu,
+        environment: EnvironmentValues
+    ) {
+        if #available(iOS 14, macCatalyst 14, tvOS 17, *) {
+            let buttonWidget = button as! ButtonWidget
+            setButtonTitle(buttonWidget, label, environment: environment)
+            buttonWidget.child.menu = menu.uiMenu
+            buttonWidget.child.showsMenuAsPrimaryAction = true
+        } else {
+            preconditionFailure("Current OS is too old to support menu buttons.")
+        }
+    }
+
+    public func setApplicationMenu(_ submenus: [ResolvedMenu.Submenu]) {
+        #if targetEnvironment(macCatalyst)
+            let appDelegate = UIApplication.shared.delegate as! ApplicationDelegate
+            appDelegate.menu = submenus
+        #else
+            // Once keyboard shortcuts are implemented, it might be possible to do them on more
+            // platforms than just Mac Catalyst. For now, this is a no-op.
+            print("UIKitBackend: ignoring \(#function) call")
+        #endif
+    }
+}

Sources/UIKitBackend/UIKitBackend.swift

@@ -14,6 +14,7 @@ public final class UIKitBackend: AppBackend {
     public let defaultPaddingAmount = 15
     public let requiresToggleSwitchSpacer = true
     public let defaultToggleStyle = ToggleStyle.switch
+    public let menuImplementationStyle = MenuImplementationStyle.menuButton
 
     // TODO: When tables are supported, update these
     public let defaultTableRowContentHeight = -1
@@ -110,11 +111,6 @@ public final class UIKitBackend: AppBackend {
 
     public func show(widget: Widget) {
     }
-
-    // TODO: Menus
-    public typealias Menu = Never
-    public func setApplicationMenu(_ submenus: [ResolvedMenu.Submenu]) {
-    }
 }
 
 extension App {
@@ -160,6 +156,8 @@ open class ApplicationDelegate: UIResponder, UIApplicationDelegate {
         }
     }
 
+    var menu: [ResolvedMenu.Submenu] = []
+
     public required override init() {
         super.init()
     }
@@ -215,6 +213,49 @@ open class ApplicationDelegate: UIResponder, UIApplicationDelegate {
 
         return true
     }
+
+    /// Map a menu's label to its identifier.
+    ///
+    /// The commands API only gives control over the label of each menu. Override this method if
+    /// you also need to control the menus' identifiers.
+    ///
+    /// This method is only used on Mac Catalyst.
+    open func mapMenuIdentifier(_ label: String) -> UIMenu.Identifier {
+        switch label {
+            case "File": .file
+            case "Edit": .edit
+            case "View": .view
+            case "Window": .window
+            case "Help": .help
+            default:
+                if let bundleId = Bundle.main.bundleIdentifier {
+                    .init(rawValue: "\(bundleId).\(label)")
+                } else {
+                    .init(rawValue: label)
+                }
+        }
+    }
+
+    /// Asks the receiving responder to add and remove items from a menu system.
+    ///
+    /// When targeting Mac Catalyst, you should call `super.buildMenu(with: builder)` at some
+    /// point in your implementation. If you do not, then calls to
+    /// ``SwiftCrossUI/Scene/commands(_:)`` will have no effect.
+    open override func buildMenu(with builder: any UIMenuBuilder) {
+        guard builder.system == .main else { return }
+
+        for submenu in menu {
+            let menuIdentifier = mapMenuIdentifier(submenu.label)
+            let menu = UIKitBackend.transformMenu(
+                content: submenu.content, label: submenu.label, identifier: menuIdentifier)
+
+            if builder.menu(for: menuIdentifier) == nil {
+                builder.insertChild(menu, atEndOfMenu: .root)
+            } else {
+                builder.replace(menu: menuIdentifier, with: menu)
+            }
+        }
+    }
 }
 
 /// The root class for scene delegates of SwiftCrossUI apps.