- Skip benchmarking altogether.

Author: general-kroll-4-life

.github/workflows/build.yml

@@ -705,59 +705,59 @@ jobs:
       if: success()
       run: python cicd/python/build.py --verbose --test
 
-    - name: Benchmark
-      if: success()
-      run: |
-        outFile="cicd/log/current-bench-nocache.txt"
-        baselineRefFile="cicd/ref/bench/baseline-go-bench.log"
-        thresholdRefFile="cicd/ref/bench/max-threshold-go-bench.log"
-        go test -run='^$' -bench . -benchtime=100x -count=6 \
-          --tags "sqlite_stackql" --ldflags "-X stackql/internal/stackql/planbuilder.PlanCacheEnabled=false"  \
-          ./... | tee ${outFile}
-        # shellcheck disable=SC2181
-        if [ "$?" = "0" ]; then
-          echo "Benchmarking run completed successfully"
-        else
-          echo "Benchmarking run failed"
-          exit 1
-        fi
-        echo ""
-        echo "##### Raw benchstat on current run #####"
-        echo ""
-        benchstat ${outFile} | tee cicd/log/raw-benchstat.txt
-        echo ""
-        echo "##### Comparing to baseline #####"
-        echo ""
-        benchstat -row .name -table .config -ignore goos,goarch,cpu ${baselineRefFile} ${outFile} | tee cicd/log/comparison-benchstat.txt
-        echo ""
-        echo "##### Comparing to max threshold #####"
-        echo ""
-        benchstat -row .name -table .config -ignore goos,goarch,cpu ${thresholdRefFile} ${outFile} | tee cicd/log/threshold-comparison-benchstat.txt
-        # shellcheck disable=SC2002,SC2062
-        comparisons=$( cat cicd/log/threshold-comparison-benchstat.txt \
-          | sed 's/.*\([+-][0-9][0-9]\.[0-9][0-9]*[%]\).*/\1/' \
-          | grep [+-][0-9][0-9]*\.[0-9][0-9]*[%] \
-        )
-        echo ""
-        echo "##### Comparisons #####"
-        echo ""
-        echo "${comparisons}"
-        # shellcheck disable=SC2062
-        nonNegativeComparisons=$( echo "${comparisons}" \
-          | grep -v [-].* \
-          || true
-        )
-        echo "completed comparison logic"
-        if [ -z "${nonNegativeComparisons}" ]; then
-          echo "All max threshold comparisons are negative: this is acceptable"
-        else
-          echo "Some max threshold comparisons are positive or zero: this is unacceptable"
-          echo ""
-          echo "##### Non-negative comparisons #####"
-          echo "${nonNegativeComparisons}"
-          echo ""
-          exit 1
-        fi
+    # - name: Benchmark
+    #   if: success()
+    #   run: |
+    #     outFile="cicd/log/current-bench-nocache.txt"
+    #     baselineRefFile="cicd/ref/bench/baseline-go-bench.log"
+    #     thresholdRefFile="cicd/ref/bench/max-threshold-go-bench.log"
+    #     go test -run='^$' -bench . -benchtime=100x -count=6 \
+    #       --tags "sqlite_stackql" --ldflags "-X stackql/internal/stackql/planbuilder.PlanCacheEnabled=false"  \
+    #       ./... | tee ${outFile}
+    #     # shellcheck disable=SC2181
+    #     if [ "$?" = "0" ]; then
+    #       echo "Benchmarking run completed successfully"
+    #     else
+    #       echo "Benchmarking run failed"
+    #       exit 1
+    #     fi
+    #     echo ""
+    #     echo "##### Raw benchstat on current run #####"
+    #     echo ""
+    #     benchstat ${outFile} | tee cicd/log/raw-benchstat.txt
+    #     echo ""
+    #     echo "##### Comparing to baseline #####"
+    #     echo ""
+    #     benchstat -row .name -table .config -ignore goos,goarch,cpu ${baselineRefFile} ${outFile} | tee cicd/log/comparison-benchstat.txt
+    #     echo ""
+    #     echo "##### Comparing to max threshold #####"
+    #     echo ""
+    #     benchstat -row .name -table .config -ignore goos,goarch,cpu ${thresholdRefFile} ${outFile} | tee cicd/log/threshold-comparison-benchstat.txt
+    #     # shellcheck disable=SC2002,SC2062
+    #     comparisons=$( cat cicd/log/threshold-comparison-benchstat.txt \
+    #       | sed 's/.*\([+-][0-9][0-9]\.[0-9][0-9]*[%]\).*/\1/' \
+    #       | grep [+-][0-9][0-9]*\.[0-9][0-9]*[%] \
+    #     )
+    #     echo ""
+    #     echo "##### Comparisons #####"
+    #     echo ""
+    #     echo "${comparisons}"
+    #     # shellcheck disable=SC2062
+    #     nonNegativeComparisons=$( echo "${comparisons}" \
+    #       | grep -v [-].* \
+    #       || true
+    #     )
+    #     echo "completed comparison logic"
+    #     if [ -z "${nonNegativeComparisons}" ]; then
+    #       echo "All max threshold comparisons are negative: this is acceptable"
+    #     else
+    #       echo "Some max threshold comparisons are positive or zero: this is unacceptable"
+    #       echo ""
+    #       echo "##### Non-negative comparisons #####"
+    #       echo "${nonNegativeComparisons}"
+    #       echo ""
+    #       exit 1
+    #     fi
 
     - name: Create certificates for robot tests
       run: |