- RE-include sqlite3 mathematical functions.

Author: general-kroll-4-life

.github/workflows/build.yml

@@ -26,7 +26,7 @@ on:
       - ".github/workflows/scenario.yaml"
 
 env:
-  GOTESTCMD: "go test -timeout 1200s --tags \"sqlite_stackql\" -v ./..."
+  GOTESTCMD: "go test -timeout 1200s --tags \"sqlite_stackql sqlite_math_functions\" -v ./..."
   TESTSCRIPT: "test/python/main.py"
   GOPRIVATE: github.com/stackql/*
   GH_ACCESS_TOKEN: ${{ secrets.ACTIONS_PRIVATE_PACKAGE_SECRET }}
@@ -313,7 +313,7 @@ jobs:
         baselineRefFile="cicd/ref/bench/baseline-go-bench.log"
         thresholdRefFile="cicd/ref/bench/max-threshold-go-bench.log"
         go test -run='^$' -bench . -benchtime=100x -count=6 \
-          --tags "sqlite_stackql" --ldflags "-X stackql/internal/stackql/planbuilder.PlanCacheEnabled=false"  \
+          --tags "sqlite_stackql sqlite_math_functions" --ldflags "-X stackql/internal/stackql/planbuilder.PlanCacheEnabled=false"  \
           ./... | tee ${outFile}
         # shellcheck disable=SC2181
         if [ "$?" = "0" ]; then
@@ -569,7 +569,7 @@ jobs:
         baselineRefFile="cicd/ref/bench/baseline-go-bench.log"
         thresholdRefFile="cicd/ref/bench/max-threshold-go-bench.log"
         go test -run='^$' -bench . -benchtime=100x -count=6 \
-          --tags "sqlite_stackql" --ldflags "-X stackql/internal/stackql/planbuilder.PlanCacheEnabled=false"  \
+          --tags "sqlite_stackql sqlite_math_functions" --ldflags "-X stackql/internal/stackql/planbuilder.PlanCacheEnabled=false"  \
           ./... | tee ${outFile}
         # shellcheck disable=SC2181
         if [ "$?" = "0" ]; then

.vscode/launch.json

@@ -198,9 +198,9 @@
       "type": "pickString",
       "id": "buildFlags",
       "description": "Extra Build Flags for debug; cannot place elsewhere",
-      "default": "-tags=sqlite_stackql",
+      "default": "-tags=sqlite_stackql sqlite_math_functions",
       "options": [
-        "-tags=sqlite_stackql"
+        "-tags=sqlite_stackql sqlite_math_functions"
       ]
     },
     {

.vscode/settings.json

@@ -10,9 +10,9 @@
   "editor.insertSpaces": true,
   "cmake.configureOnOpen": false,
   "go.buildFlags": [
-    "-tags=sqlite_stackql"
+    "-tags=sqlite_stackql sqlite_math_functions"
   ],
-  "go.testTags": "sqlite_stackql",
+  "go.testTags": "sqlite_stackql sqlite_math_functions",
   "todohighlight.keywordsPattern": "TODO:|FIXME:|BLOCK|END_BLOCK", //highlight `TODO:`,`FIXME:` or commented content between parentheses
   "todohighlight.exclude": [
     "**/*.json"

Dockerfile

@@ -44,7 +44,7 @@ ENV SRC_DIR=/work/stackql/src
 ENV BUILD_DIR=/work/stackql/build
 
 RUN   cd ${SRC_DIR} \
-      && go test --tags "sqlite_stackql" ./... \
+      && go test --tags "sqlite_stackql sqlite_math_functions" ./... \
       && go build -ldflags "-X github.com/stackql/stackql/internal/stackql/cmd.BuildMajorVersion=$BUILDMAJORVERSION \
           -X github.com/stackql/stackql/internal/stackql/cmd.BuildMinorVersion=$BUILDMINORVERSION \
           -X github.com/stackql/stackql/internal/stackql/cmd.BuildPatchVersion=$BUILDPATCHVERSION \
@@ -53,7 +53,7 @@ RUN   cd ${SRC_DIR} \
           -X \"github.com/stackql/stackql/internal/stackql/cmd.BuildDate=$BUILDDATE\" \
           -X \"stackql/internal/stackql/planbuilder.PlanCacheEnabled=$PLANCACHEENABLED\" \
           -X github.com/stackql/stackql/internal/stackql/cmd.BuildPlatform=$BUILDPLATFORM" \
-        --tags "sqlite_stackql" \
+        --tags "sqlite_stackql sqlite_math_functions" \
         -o ${BUILD_DIR}/stackql ./stackql
 
 FROM python:3.11-bullseye AS utility

cicd/python/build.py

@@ -13,7 +13,7 @@ def build_stackql(verbose :bool) -> int:
     os.environ['BUILDPATCHVERSION'] = os.environ.get('BUILDPATCHVERSION', '1')
     os.environ['CGO_ENABLED'] = os.environ.get('CGO_ENABLED', '1')
     return subprocess.call(
-        f'go build {"-x -v" if verbose else ""} --tags "sqlite_stackql" -ldflags "-X github.com/stackql/stackql/internal/stackql/cmd.BuildMajorVersion={os.environ.get("BUILDMAJORVERSION")} '
+        f'go build {"-x -v" if verbose else ""} --tags "sqlite_stackql sqlite_math_functions" -ldflags "-X github.com/stackql/stackql/internal/stackql/cmd.BuildMajorVersion={os.environ.get("BUILDMAJORVERSION")} '
         f'-X github.com/stackql/stackql/internal/stackql/cmd.BuildMinorVersion={os.environ.get("BUILDMINORVERSION")} '
         f'-X github.com/stackql/stackql/internal/stackql/cmd.BuildPatchVersion={os.environ.get("BUILDPATCHVERSION")} '
         f'-X github.com/stackql/stackql/internal/stackql/cmd.BuildCommitSHA={os.environ.get("BUILDCOMMITSHA", "")} '
@@ -28,7 +28,7 @@ def build_stackql(verbose :bool) -> int:
 
 def unit_test_stackql(verbose :bool) -> int:
     return subprocess.call(
-        f'go test -timeout 1200s {"-v" if verbose else ""} --tags "sqlite_stackql"  ./...',
+        f'go test -timeout 1200s {"-v" if verbose else ""} --tags "sqlite_stackql sqlite_math_functions"  ./...',
         shell=True
     )
 

docs/developer_guide.md

@@ -49,7 +49,7 @@ As of now, `stackql` handles `xml` SERDE through the core, and does not route th
 
 ```bash
 env CGO_ENABLED=1 go build \
-  --tags "sqlite_stackql" \
+  --tags "sqlite_stackql sqlite_math_functions" \
   -ldflags "-X github.com/stackql/stackql/internal/stackql/cmd.BuildMajorVersion=${BUILDMAJORVERSION:-1} \
   -X github.com/stackql/stackql/internal/stackql/cmd.BuildMinorVersion=${BUILDMINORVERSION:-1} \
   -X github.com/stackql/stackql/internal/stackql/cmd.BuildPatchVersion=${BUILDPATCHVERSION:-1} \
@@ -69,7 +69,7 @@ At this time, we are not dogmatic about how to implement unit tests.  Aspiration
 To run all unit tests:
 
 ```bash
-go test -timeout 1200s --tags "sqlite_stackql" ./...
+go test -timeout 1200s --tags "sqlite_stackql sqlite_math_functions" ./...
 ```
 
 ### Robot tests
@@ -184,7 +184,7 @@ Requirements are [detailed in the root README](/README.md#system-requirements).
 
 Local testing of the application:
 
-1. Run `go test --tags "sqlite_stackql" ./...` tests.
+1. Run `go test --tags "sqlite_stackql sqlite_math_functions" ./...` tests.
 2. Build the executable [as per the root README](/README.md#build)
 3. Perform registry rewrites as needed for mocking `python3 test/python/registry-rewrite.py`.
 3. Run robot tests:
@@ -203,7 +203,7 @@ Test coverage is sparse.  Regressions are mitigated by `go test` integration tes
 #### Point in time gotest coverage
 
 If not already done, then install 'cover' with `go get golang.org/x/tools/cmd/cover`.  
-Then: `go test --tags "sqlite_stackql" -cover ../...`.
+Then: `go test --tags "sqlite_stackql sqlite_math_functions" -cover ../...`.
 
 ### Functional and Integration testing