- Added robot test Insert Returning Simple Projection.

general-kroll-4-life · general-kroll-4-life · commit c5479462b26e · 2025-07-06T00:33:50.000+10:00
diff --git a/internal/stackql/parserutil/parser_util.go b/internal/stackql/parserutil/parser_util.go
@@ -88,7 +88,10 @@ func ExtractSelectColumnNames(selStmt *sqlparser.Select, formatter sqlparser.Nod
 	return colNames, err
 }
 
-func ExtractInsertReturningColumnNames(insertStmt *sqlparser.Insert, formatter sqlparser.NodeFormatter) ([]ColumnHandle, error) {
+func ExtractInsertReturningColumnNames(
+	insertStmt *sqlparser.Insert,
+	formatter sqlparser.NodeFormatter,
+) ([]ColumnHandle, error) {
 	var colNames []ColumnHandle
 	var err error
 	for _, node := range insertStmt.SelectExprs {
diff --git a/internal/stackql/primitivegenerator/statement_analyzer.go b/internal/stackql/primitivegenerator/statement_analyzer.go
@@ -1002,7 +1002,7 @@ func (pb *standardPrimitiveGenerator) buildRequestContext(
 	return err
 }
 
-//nolint:gocognit,funlen // TODO: review
+//nolint:gocognit,funlen,gocyclo,cyclop // TODO: review
 func (pb *standardPrimitiveGenerator) AnalyzeInsert(pbi planbuilderinput.PlanBuilderInput) error {
 	handlerCtx := pbi.GetHandlerCtx()
 	annotatedAST := pbi.GetAnnotatedAST()
diff --git a/internal/stackql/sql_system/postgres.go b/internal/stackql/sql_system/postgres.go
@@ -1237,7 +1237,7 @@ func (eng *postgresSystem) generateSelectDML(
 				quotedColNames,
 				", ",
 			),
-			eng.tableCatalog,
+			eng.tableSchema,
 			tableName,
 			aliasStr,
 		),

Original file line number	Diff line number	Diff line change
`@@ -1002,7 +1002,7 @@ func (pb *standardPrimitiveGenerator) buildRequestContext(`
`1002`	`1002`	`return err`
`1003`	`1003`	`}`
`1004`	`1004`
`1005`		`-//nolint:gocognit,funlen // TODO: review`
	`1005`	`+//nolint:gocognit,funlen,gocyclo,cyclop // TODO: review`
`1006`	`1006`	`func (pb *standardPrimitiveGenerator) AnalyzeInsert(pbi planbuilderinput.PlanBuilderInput) error {`
`1007`	`1007`	`handlerCtx := pbi.GetHandlerCtx()`
`1008`	`1008`	`annotatedAST := pbi.GetAnnotatedAST()`