Skip to content

Commit df66db1

Browse files
- Amended linting directives.
1 parent 3991472 commit df66db1

File tree

5 files changed

+18
-3
lines changed

5 files changed

+18
-3
lines changed

.golangci.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,17 @@ linters:
174174
path: internal\/test\/.*\.go
175175
- linters:
176176
- mnd
177+
- revive
178+
- nolintlint
179+
- lll
180+
- gochecknoglobals
181+
- unused
177182
path: pkg\/mcp_server\/.*\.go
183+
- linters:
184+
- gochecknoglobals
185+
- lll
186+
- revive
187+
path: mcp_client\/cmd\/.*\.go
178188
- linters:
179189
- staticcheck
180190
path: ast_format_postgres\.go

internal/stackql/cmd/mcp.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"github.com/stackql/stackql/pkg/mcp_server"
2828
)
2929

30+
//nolint:gochecknoglobals // cobra pattern
3031
var (
3132
mcpServerType string // overwritten by flag
3233
mcpConfig string // overwritten by flag

mcp_client/cmd/exec.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ var execCmd = &cobra.Command{
4848
if outPutErr != nil {
4949
panic(fmt.Sprintf("error marshaling output: %v", outPutErr))
5050
}
51+
//nolint:forbidigo // legacy
5152
fmt.Println(string(output))
5253
},
5354
}

pkg/mcp_server/client.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,14 @@ func (c *httpMCPClient) InspectTools() ([]map[string]any, error) {
9393
c.logger.Println("Getting time for each city...")
9494
for _, city := range cities {
9595
// Call the tool.
96-
result, err := session.CallTool(ctx, &mcp.CallToolParams{
96+
result, resultErr := session.CallTool(ctx, &mcp.CallToolParams{
9797
Name: "cityTime",
9898
Arguments: map[string]any{
9999
"city": city,
100100
},
101101
})
102-
if err != nil {
103-
c.logger.Infof("Failed to get time for %s: %v\n", city, err)
102+
if resultErr != nil {
103+
c.logger.Infof("Failed to get time for %s: %v\n", city, resultErr)
104104
continue
105105
}
106106

pkg/mcp_server/server.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ func (s *simpleMCPServer) runHTTPServer(server *mcp.Server, address string) erro
5555
s.logger.Debugf("Available tool: cityTime (cities: nyc, sf, boston)")
5656

5757
// Start the HTTP server with logging handler.
58+
//nolint:gosec // TODO: find viable alternative to http.ListenAndServe
5859
if err := http.ListenAndServe(address, handlerWithLogging); err != nil {
5960
s.logger.Errorf("Server failed: %v", err)
6061
return err
@@ -76,6 +77,8 @@ func NewExampleBackendServer(config *Config, logger *logrus.Logger) (MCPServer,
7677
// }
7778

7879
// NewMCPServer creates a new MCP server with the provided configuration and backend.
80+
//
81+
//nolint:gocognit,funlen // ok
7982
func newMCPServer(config *Config, backend Backend, logger *logrus.Logger) (MCPServer, error) {
8083
if config == nil {
8184
config = DefaultConfig()

0 commit comments

Comments
 (0)