regression: UserAvatar should always render BaseAvatar (RocketChat#34061)

dougfabris · web-flow · commit b604dabf4e63 · 2024-11-28T12:40:02.000-05:00
diff --git a/packages/ui-avatar/src/components/UserAvatar.tsx b/packages/ui-avatar/src/components/UserAvatar.tsx
@@ -31,7 +31,8 @@ const UserAvatar = ({ username, userId, etag, ...rest }: UserAvatarProps) => {
 		return <BaseAvatar url={url} data-username={username} title={username} {...props} />;
 	}
 
-	throw new Error('ui-avatar(UserAvatar) - Either username or userId must be provided');
+	// TODO: We should throw an Error after fixing the issue in Composer passing the username undefined
+	return null;
 };
 
 export default memo(UserAvatar);

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@ const UserAvatar = ({ username, userId, etag, ...rest }: UserAvatarProps) => {`
`31`	`31`	`return <BaseAvatar url={url} data-username={username} title={username} {...props} />;`
`32`	`32`	`}`
`33`	`33`
`34`		`- throw new Error('ui-avatar(UserAvatar) - Either username or userId must be provided');`
	`34`	`+ // TODO: We should throw an Error after fixing the issue in Composer passing the username undefined`
	`35`	`+ return null;`
`35`	`36`	`};`
`36`	`37`
`37`	`38`	`export default memo(UserAvatar);`