Skip to content

Commit 2f8f8d9

Browse files
committed
Resolver: don't inherit overridden graphql_name
1 parent eb4cac0 commit 2f8f8d9

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

lib/graphql/schema/resolver.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class Resolver
2222
include Schema::Member::GraphQLTypeNames
2323
# Really we only need description & comment from here, but:
2424
extend Schema::Member::BaseDSLMethods
25-
extend Member::BaseDSLMethods::ConfigurationExtension
2625
extend GraphQL::Schema::Member::HasArguments
2726
extend GraphQL::Schema::Member::HasValidators
2827
include Schema::Member::HasPath
@@ -404,6 +403,11 @@ def extensions
404403
end
405404
end
406405

406+
def inherited(child_class)
407+
child_class.description(description)
408+
super
409+
end
410+
407411
private
408412

409413
attr_reader :own_extensions

spec/graphql/schema/resolver_spec.rb

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -726,6 +726,19 @@ def exec_query(*args, **kwargs)
726726
end
727727
end
728728

729+
describe "graphql_name" do
730+
class NameParentResolver < GraphQL::Schema::Resolver
731+
graphql_name "NameOverride"
732+
end
733+
734+
class NameChildResolver < NameParentResolver
735+
end
736+
it "isn't inherited" do
737+
assert_equal "NameOverride", NameParentResolver.graphql_name
738+
assert_equal "NameChildResolver", NameChildResolver.graphql_name
739+
end
740+
end
741+
729742
describe "description" do
730743
it "is inherited" do
731744
expected_desc = "Adds object.value to ast_node.name.size"

0 commit comments

Comments
 (0)