ROX-21884: add ability to override tenant resources values by clusterIDs (#2401)

* add ability to override tenant resources values by clusterIDs

* fix gotag

Author: johannes94

internal/central/pkg/gitops/config.go

@@ -92,6 +92,7 @@ type TenantResourceConfig struct {
 // will be applied on top of the default tenant resource values configuration.
 type TenantResourceOverride struct {
 	InstanceIDs []string `json:"instanceIds"`
+	ClusterIDs  []string `json:"clusterIds"`
 	Values      string   `json:"values"`
 }
 

internal/central/pkg/gitops/service.go

@@ -24,7 +24,7 @@ func RenderTenantResourceValues(params CentralParams, config Config) (map[string
 	}
 
 	for _, override := range config.TenantResources.Overrides {
-		if !shouldApplyOverride(override.InstanceIDs, params) {
+		if !shouldApplyOverride(override, params) {
 			continue
 		}
 		rendered, err := renderPatchTemplate(override.Values, params)
@@ -77,15 +77,26 @@ type CentralParams struct {
 }
 
 // shouldApplyOverride returns true if the given Central override should be applied to the given Central instance.
-func shouldApplyOverride(instanceIDs []string, ctx CentralParams) bool {
-	for _, d := range instanceIDs {
+func shouldApplyOverride(override TenantResourceOverride, ctx CentralParams) bool {
+	for _, d := range override.InstanceIDs {
 		if d == "*" {
 			return true
 		}
 		if d == ctx.ID {
 			return true
 		}
 	}
+
+	for _, d := range override.ClusterIDs {
+		if d == "*" {
+			return true
+		}
+
+		if d == ctx.ClusterID {
+			return true
+		}
+	}
+
 	return false
 }
 

internal/central/pkg/gitops/service_test.go

@@ -137,6 +137,27 @@ func TestRenderTenantResourceValues(t *testing.T) {
 				require.NoError(t, err)
 				assert.Equal(t, map[string]interface{}{"foo": "central-1"}, got)
 			},
+		}, {
+			name: "overrides with clusterID",
+			params: CentralParams{
+				ID:        "central-1",
+				ClusterID: "test-cluster-id",
+			},
+			config: Config{
+				TenantResources: TenantResourceConfig{
+					Default: `{"foo": "bar"}`,
+					Overrides: []TenantResourceOverride{
+						{
+							ClusterIDs: []string{"test-cluster-id"},
+							Values:     `{"foo": "override"}`,
+						},
+					},
+				},
+			},
+			assert: func(t *testing.T, got map[string]interface{}, err error) {
+				require.NoError(t, err)
+				assert.Equal(t, map[string]interface{}{"foo": "override"}, got)
+			},
 		},
 	}
 	for _, tt := range tests {