fix: use is-standard to check new recipient addr

Author: hstove

contrib/core-contract-tests/tests/clarigen-types.ts

@@ -4615,6 +4615,11 @@ export const contracts = {
         type: "uint128",
         access: "constant",
       } as TypedAbiVariable<bigint>,
+      ERR_INVALID_RECIPIENT: {
+        name: "ERR_INVALID_RECIPIENT",
+        type: "uint128",
+        access: "constant",
+      } as TypedAbiVariable<bigint>,
       ERR_NOTHING_TO_CLAIM: {
         name: "ERR_NOTHING_TO_CLAIM",
         type: "uint128",
@@ -4663,6 +4668,7 @@ export const contracts = {
     },
     constants: {
       DEPLOY_BLOCK_HEIGHT: 3n,
+      ERR_INVALID_RECIPIENT: 103n,
       ERR_NOTHING_TO_CLAIM: 102n,
       ERR_NOT_ALLOWED: 101n,
       INITIAL_MINT_AMOUNT: 200_000_000_000_000n,

contrib/core-contract-tests/tests/sip-031/sip-031.test.ts

@@ -1,5 +1,10 @@
 import { project, accounts } from '../clarigen-types'; // where your [types.output] was specified
-import { CoreNodeEventType, cvToValue, projectFactory } from '@clarigen/core';
+import {
+  CoreNodeEventType,
+  cvToValue,
+  projectFactory,
+  MAINNET_BURN_ADDRESS,
+} from '@clarigen/core';
 import { filterEvents, rov, txErr, txOk } from '@clarigen/test';
 import { test, expect } from 'vitest';
 
@@ -404,3 +409,25 @@ test('claiming after waiting more than 1 month', () => {
       constants.INITIAL_MINT_VESTING_AMOUNT / 24n,
   );
 });
+
+test('recipient cannot be set to a non-standard address', () => {
+  const mainnetStandard = MAINNET_BURN_ADDRESS;
+  const standardReceipt = txErr(
+    contract.updateRecipient(mainnetStandard),
+    accounts.deployer.address,
+  );
+  expect(standardReceipt.value).toBe(constants.ERR_INVALID_RECIPIENT);
+
+  const mainnetContract = `${MAINNET_BURN_ADDRESS}.blah`;
+  const contractReceipt = txErr(
+    contract.updateRecipient(mainnetContract),
+    accounts.deployer.address,
+  );
+  expect(contractReceipt.value).toBe(constants.ERR_INVALID_RECIPIENT);
+});
+
+test('recipient can be set to a contract', () => {
+  const contractAddr = `${accounts.deployer.address}.blah`;
+  txOk(contract.updateRecipient(contractAddr), accounts.deployer.address);
+  expect(rov(contract.getRecipient())).toBe(contractAddr);
+});

stackslib/src/chainstate/stacks/boot/sip-031.clar

@@ -14,6 +14,7 @@
 
 (define-constant ERR_NOT_ALLOWED u101)
 (define-constant ERR_NOTHING_TO_CLAIM u102)
+(define-constant ERR_INVALID_RECIPIENT u103)
 
 ;; The amount initially minted to the contract is 200M STX
 (define-constant INITIAL_MINT_AMOUNT u200000000000000) ;; 200,000,000 STX
@@ -59,6 +60,7 @@
 (define-public (update-recipient (new-recipient principal))
   (begin
     (try! (validate-caller))
+    (asserts! (is-standard new-recipient) (err ERR_INVALID_RECIPIENT))
     (print {
       topic: "update-recipient",
       old-recipient: (var-get recipient),