feat: test for indirect calling update-recipient

Author: hstove

contrib/core-contract-tests/Clarinet.toml

@@ -40,6 +40,12 @@ clarity_version = 3
 epoch = 3.0
 depends_on = []
 
+[contracts.sip-031-indirect]
+path = "contracts/sip-031-indirect.clar"
+clarity_version = 3
+epoch = 3.0
+depends_on = ["sip-031"]
+
 [contracts.bns_test]
 path = "./tests/bns_test.clar"
 clarity_version = 2

contrib/core-contract-tests/contracts/sip-031-indirect.clar

@@ -0,0 +1,6 @@
+;; This is a wrapper contract to test calling `.sip-031`
+;; from an outside contract.
+
+(define-public (update-recipient (new-recipient principal))
+  (contract-call? 'ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.sip-031 update-recipient new-recipient)
+)

contrib/core-contract-tests/deployments/default.simnet-plan.yaml

@@ -92,4 +92,9 @@ plan:
             emulated-sender: ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM
             path: "../../stackslib/src/chainstate/stacks/boot/sip-031.clar"
             clarity-version: 3
+        - emulated-contract-publish:
+            contract-name: sip-031-indirect
+            emulated-sender: ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM
+            path: contracts/sip-031-indirect.clar
+            clarity-version: 3
       epoch: "3.0"

contrib/core-contract-tests/tests/clarigen-types.ts

@@ -4601,6 +4601,27 @@ export const contracts = {
     clarity_version: "Clarity3",
     contractName: "sip-031",
   },
+  sip031Indirect: {
+    functions: {
+      updateRecipient: {
+        name: "update-recipient",
+        access: "public",
+        args: [{ name: "new-recipient", type: "principal" }],
+        outputs: { type: { response: { ok: "bool", error: "int128" } } },
+      } as TypedAbiFunction<
+        [newRecipient: TypedAbiArg<string, "newRecipient">],
+        Response<boolean, bigint>
+      >,
+    },
+    maps: {},
+    variables: {},
+    constants: {},
+    non_fungible_tokens: [],
+    fungible_tokens: [],
+    epoch: "Epoch30",
+    clarity_version: "Clarity3",
+    contractName: "sip-031-indirect",
+  },
 } as const;
 
 export const accounts = {
@@ -4654,6 +4675,7 @@ export const identifiers = {
   signers: "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.signers",
   signersVoting: "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.signers-voting",
   sip031: "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.sip-031",
+  sip031Indirect: "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.sip-031-indirect",
 } as const;
 
 export const simnet = {
@@ -4705,6 +4727,12 @@ export const deployments = {
     testnet: null,
     mainnet: null,
   },
+  sip031Indirect: {
+    devnet: "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.sip-031-indirect",
+    simnet: "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM.sip-031-indirect",
+    testnet: null,
+    mainnet: null,
+  },
 } as const;
 
 export const project = {

contrib/core-contract-tests/tests/sip-031/sip-031.test.ts

@@ -6,6 +6,7 @@ import { test, expect } from 'vitest';
 const contracts = projectFactory(project, 'simnet');
 const contract = contracts.sip031;
 const constants = contract.constants;
+const indirectContract = contracts.sip031Indirect;
 
 test('initial recipient should be the deployer', () => {
   const value = rov(contract.getRecipient());
@@ -31,4 +32,9 @@ test('updated recipient can re-update the recipient', () => {
 
   txOk(contract.updateRecipient(accounts.wallet_2.address), accounts.wallet_1.address)
   expect(rov(contract.getRecipient())).toBe(accounts.wallet_2.address);
-});
+});
+
+test('recipient cannot be updated from an indirect contract', () => {
+  const receipt = txErr(indirectContract.updateRecipient(accounts.wallet_1.address), accounts.deployer.address)
+  expect(receipt.value).toBe(constants.ERR_NOT_ALLOWED);
+});