CRC: reduce needless vector creation

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jferrant

stackslib/src/burnchains/tests/mod.rs

@@ -135,14 +135,14 @@ pub struct TestMinerFactory {
 impl TestMiner {
     pub fn new(
         burnchain: &Burnchain,
-        privks: &[StacksPrivateKey],
+        privks: Vec<StacksPrivateKey>,
         num_sigs: u16,
         hash_mode: &AddressHashMode,
         chain_id: u32,
     ) -> TestMiner {
         TestMiner {
             burnchain: burnchain.clone(),
-            privks: privks.to_vec(),
+            privks,
             num_sigs,
             hash_mode: hash_mode.clone(),
             microblock_privks: vec![],
@@ -342,7 +342,7 @@ impl TestMinerFactory {
         }
 
         test_debug!("New miner: {:?} {}:{:?}", &hash_mode, num_sigs, &keys);
-        let mut m = TestMiner::new(burnchain, &keys, num_sigs, &hash_mode, self.chain_id);
+        let mut m = TestMiner::new(burnchain, keys, num_sigs, &hash_mode, self.chain_id);
         m.id = self.next_miner_id;
         self.next_miner_id += 1;
         m

stackslib/src/chainstate/stacks/tests/mod.rs

@@ -555,13 +555,13 @@ impl TestStacksNode {
         burn_block: &mut TestBurnchainBlock,
         miner: &mut TestMiner,
         stacks_block: &StacksBlock,
-        microblocks: &[StacksMicroblock],
+        microblocks: Vec<StacksMicroblock>,
         burn_amount: u64,
         miner_key: &LeaderKeyRegisterOp,
         parent_block_snapshot_opt: Option<&BlockSnapshot>,
     ) -> LeaderBlockCommitOp {
         self.anchored_blocks.push(stacks_block.clone());
-        self.microblocks.push(microblocks.to_vec());
+        self.microblocks.push(microblocks);
 
         test_debug!(
             "Miner {}: Commit to stacks block {} (work {},{})",
@@ -704,7 +704,7 @@ impl TestStacksNode {
             burn_block,
             miner,
             &stacks_block,
-            &microblocks,
+            microblocks.clone(),
             burn_amount,
             miner_key,
             parent_block_snapshot_opt.as_ref(),

stackslib/src/net/mod.rs

@@ -4323,7 +4323,7 @@ pub mod test {
                 &mut burn_block,
                 &mut self.miner,
                 &stacks_block,
-                &microblocks,
+                microblocks.clone(),
                 1000,
                 &last_key,
                 parent_sortition_opt.as_ref(),