Merge branch 'feat/clarity-wasm-develop' into wasm-issue-675/fix-callable-argument

Author: BowTiedWoo

.github/PULL_REQUEST_TEMPLATE.md

@@ -20,4 +20,3 @@
 - [ ] Changelog is updated
 - [ ] Required documentation changes (e.g., `docs/rpc/openapi.yaml` and `rpc-endpoints.md` for v2 endpoints, `event-dispatcher.md` for new events)
 - [ ] New clarity functions have corresponding PR in `clarity-benchmarking` repo
-- [ ] New integration test(s) added to `bitcoin-tests.yml`

.github/workflows/bitcoin-tests.yml

@@ -58,7 +58,6 @@ jobs:
         exclude:
           # The following tests are excluded from CI runs. Some of these may be
           #  worth investigating adding back into the CI
-          - test-name: tests::bitcoin_regtest::bitcoind_integration_test_segwit
           - test-name: tests::nakamoto_integrations::consensus_hash_event_dispatcher
           - test-name: tests::neon_integrations::atlas_integration_test
           - test-name: tests::neon_integrations::atlas_stress_integration_test

.github/workflows/cargo-hack-check.yml

@@ -38,13 +38,12 @@ jobs:
         with:
           persist-credentials: false
 
-      - name: Setup Rust with Cache
+      - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
         with:
           toolchain: ${{ needs.setup.outputs.rust-toolchain }}
           target: x86_64-pc-windows-gnu,x86_64-unknown-linux-gnu
-          cache: true
-          cache-key: cargo-hack-native-${{ needs.setup.outputs.rust-toolchain }}-${{ hashFiles('**/Cargo.lock') }}
+          cache: false
 
       - name: Install cargo-hack
         uses: taiki-e/install-action@2383334cf567d78771fc7d89b6b3802ef1412cf6  # v2.56.8
@@ -66,53 +65,70 @@ jobs:
             --target x86_64-pc-windows-gnu \
             --target x86_64-unknown-linux-gnu
 
-  # WASM targets - separate cache since dependencies differ
+  # WASM targets - No caching needed as it runs in parallel with longer jobs
   wasm-targets:
-    name: ${{ matrix.name }}
+    name: WASM targets
     runs-on: ubuntu-latest
     needs: setup
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - name: "Clarity & Stacks-Common WASM Web"
-            command: |
-              cargo hack check \
-                -p clarity-serialization \
-                -p stacks-common \
-                --each-feature \
-                --no-dev-deps \
-                --exclude-features=default,rusqlite,ctrlc-handler,wasm-deterministic \
-                --features=wasm-web
-
-          - name: "Clarity & Stacks-Common WASM Deterministic"
-            command: |
-              cargo hack check \
-                -p clarity-serialization \
-                -p stacks-common \
-                --each-feature \
-                --no-dev-deps \
-                --include-features=wasm-deterministic,slog_json \
-                --features=wasm-deterministic
-
     steps:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
 
-      - name: Setup Rust with Cache
+      - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
         with:
           toolchain: ${{ needs.setup.outputs.rust-toolchain }}
           target: wasm32-unknown-unknown
-          cache: true
-          cache-key: cargo-hack-wasm-${{ matrix.name }}-${{ needs.setup.outputs.rust-toolchain }}-${{ hashFiles('**/Cargo.lock') }}
+          cache: false
 
       - name: Install cargo-hack
         uses: taiki-e/install-action@2383334cf567d78771fc7d89b6b3802ef1412cf6 # v2.56.8
         with:
           tool: cargo-hack
 
+      - name: Run cargo hack check (WASM Web)
+        run: |
+          cargo hack check \
+            -p clarity-serialization \
+            -p stacks-common \
+            --each-feature \
+            --no-dev-deps \
+            --exclude-features=default,rusqlite,ctrlc-handler,wasm-deterministic \
+            --features=wasm-web
+
+      - name: Run cargo hack check (WASM Deterministic)
+        run: |
+          cargo hack check \
+            -p clarity-serialization \
+            -p stacks-common \
+            --each-feature \
+            --no-dev-deps \
+            --include-features=wasm-deterministic,slog_json \
+            --features=wasm-deterministic
+
       - name: Run cargo hack check
         run: ${{ matrix.command }}
+
+  fuzz-targets:
+    name: Fuzz targets (nightly)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          persist-credentials: false
+
+      - name: Install Rust nightly toolchain
+        uses: actions-rust-lang/setup-rust-toolchain@fb51252c7ba57d633bc668f941da052e410add48 # v1.13.0
+        with:
+          toolchain: nightly
+          cache: false
+
+      - name: Check fuzz targets
+        run: |
+          cargo +nightly check \
+            --manifest-path clarity/fuzz/Cargo.toml \
+            --bins \
+            --locked

.github/workflows/clippy.yml

@@ -26,15 +26,19 @@ jobs:
       - name: Checkout the latest code
         id: git_checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
       - name: Define Rust Toolchain
         id: define_rust_toolchain
         run: echo "RUST_TOOLCHAIN=$(cat ./rust-toolchain)" >> $GITHUB_ENV
+
       - name: Setup Rust Toolchain
         id: setup_rust_toolchain
         uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}
           components: clippy
+          cache: false
+
       - name: Clippy
         id: clippy
         run: cargo clippy-stacks

.github/workflows/constants-check.yml

@@ -17,14 +17,17 @@ jobs:
       - name: Checkout the latest code
         id: git_checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
       - name: Define Rust Toolchain
         id: define_rust_toolchain
         run: echo "RUST_TOOLCHAIN=$(cat ./rust-toolchain)" >> $GITHUB_ENV
+
       - name: Setup Rust Toolchain
         id: setup_rust_toolchain
         uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}
+          cache: false
 
       - name: Dump constants JSON
         id: consts-dump

.github/workflows/github-release.yml

@@ -91,7 +91,7 @@ jobs:
           - arch: macos # excludes macos-armv7
             cpu: armv7
           - arch: macos # excludes macos-x64
-            cpu: x86_64
+            cpu: x86-64
     steps:
       - name: Build Binary (${{ matrix.arch }}_${{ matrix.cpu }})
         uses: stacks-network/actions/stacks-core/release/create-source-binary@main

.github/workflows/nix-check.yml

@@ -38,4 +38,5 @@ jobs:
       - uses: DeterminateSystems/magic-nix-cache-action@e1c1dae8e170ed20fd2e6aaf9979ca2d3905d636  # v12
         with:
           use-flakehub: false  # Remove error when trying to authenticate without credentials
+          use-gha-cache: false # Disable uploading cache to gha cache
       - run: nix flake check ./contrib/nix

CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE
 
 ## Unreleased
 
+### Added
+
+- When determining a global transaction replay set, the state evaluator now uses a longest-common-prefix algorithm to find a replay set in the case where a single replay set has less than 70% of signer weight.
+
+### Changed
+
+- Clarity errors pertaining to syntax binding errors have been made more
+  expressive (#6337)
+
+
+## [3.2.0.0.1]
+
+### Added
+
+- Adds node-config-docsgen to automatically create config documentation (#6227)
+
 ### Fixed
 
 - Fixed a typo in the metrics_identifier route from `/v2/stackedb/:principal/:contract_name/replicas` to `/v2/stackerdb/:principal/:contract_name/replicas`. Note: This may be a breaking change for systems relying on the incorrect route. Please update any metrics tools accordingly.