feat: do not allow reorg when timing is equal to allowed time

obycode · obycode · commit 231789528be9 · 2025-02-20T13:58:37.000-05:00
Make it strictly `&lt;`, not `&lt;=` the `first_proposal_burn_block_timing`.
This seems appropriate to err on the side of not allowing the reorg, and
it also makes testing easier.
diff --git a/stacks-signer/src/chainstate.rs b/stacks-signer/src/chainstate.rs
@@ -493,7 +493,7 @@ impl SortitionsView {
                         0
                     };
                     if Duration::from_secs(proposal_to_sortition)
-                        <= *first_proposal_burn_block_timing
+                        < *first_proposal_burn_block_timing
                     {
                         info!(
                             "Miner is not building off of most recent tenure. A tenure they reorg has already mined blocks, but the block was poorly timed, allowing the reorg.";

Original file line number	Diff line number	Diff line change
`@@ -493,7 +493,7 @@ impl SortitionsView {`
`493`	`493`	`0`
`494`	`494`	`};`
`495`	`495`	`if Duration::from_secs(proposal_to_sortition)`
`496`		`- <= *first_proposal_burn_block_timing`
	`496`	`+ < *first_proposal_burn_block_timing`
`497`	`497`	`{`
`498`	`498`	`info!(`
`499`	`499`	`"Miner is not building off of most recent tenure. A tenure they reorg has already mined blocks, but the block was poorly timed, allowing the reorg.";`