Skip to content

Commit 2b36268

Browse files
committed
chore: revert change moving request creation out of loop
This avoids a clone in the happy case (where no retry is needed).
1 parent 334cf0f commit 2b36268

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

testnet/stacks-node/src/event_dispatcher.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -434,16 +434,16 @@ impl EventObserver {
434434
// Cap the backoff at 3x the timeout
435435
let max_backoff = timeout.saturating_mul(3);
436436

437-
let mut request = StacksHttpRequest::new_for_peer(
438-
peerhost.clone(),
439-
"POST".into(),
440-
url.path().into(),
441-
HttpRequestContents::new().payload_json(payload.clone()),
442-
)
443-
.unwrap_or_else(|_| panic!("FATAL: failed to encode infallible data as HTTP request"));
444-
request.add_header("Connection".into(), "close".into());
445437
loop {
446-
match send_http_request(host, port, request.clone(), timeout) {
438+
let mut request = StacksHttpRequest::new_for_peer(
439+
peerhost.clone(),
440+
"POST".into(),
441+
url.path().into(),
442+
HttpRequestContents::new().payload_json(payload.clone()),
443+
)
444+
.unwrap_or_else(|_| panic!("FATAL: failed to encode infallible data as HTTP request"));
445+
request.add_header("Connection".into(), "close".into());
446+
match send_http_request(host, port, request, timeout) {
447447
Ok(response) => {
448448
if response.preamble().status_code == 200 {
449449
debug!(

0 commit comments

Comments
 (0)