Remove unnecesssary elses in handle_block_validate_*

jferrant · jferrant · commit 3d67fcbca55e · 2024-10-29T08:02:59.000-07:00
Signed-off-by: Jacinta Ferrant &lt;jacinta@trustmachines.co&gt;
diff --git a/stacks-signer/src/v0/signer.rs b/stacks-signer/src/v0/signer.rs
@@ -520,9 +520,8 @@ impl Signer {
                 {
                     debug!("{self}: Received block validation for a block that is already marked as {}. Ignoring...", block_info.state);
                     return None;
-                } else {
-                    block_info
                 }
+                block_info
             }
             Ok(None) => {
                 // We have not seen this block before. Why are we getting a response for it?
@@ -569,9 +568,8 @@ impl Signer {
                 {
                     debug!("{self}: Received block validation for a block that is already marked as {}. Ignoring...", block_info.state);
                     return None;
-                } else {
-                    block_info
                 }
+                block_info
             }
             Ok(None) => {
                 // We have not seen this block before. Why are we getting a response for it?

Original file line number	Diff line number	Diff line change
`@@ -520,9 +520,8 @@ impl Signer {`
`520`	`520`	`{`
`521`	`521`	`debug!("{self}: Received block validation for a block that is already marked as {}. Ignoring...", block_info.state);`
`522`	`522`	`return None;`
`523`		`- } else {`
`524`		`- block_info`
`525`	`523`	`}`
	`524`	`+ block_info`
`526`	`525`	`}`
`527`	`526`	`Ok(None) => {`
`528`	`527`	`// We have not seen this block before. Why are we getting a response for it?`
`@@ -569,9 +568,8 @@ impl Signer {`
`569`	`568`	`{`
`570`	`569`	`debug!("{self}: Received block validation for a block that is already marked as {}. Ignoring...", block_info.state);`
`571`	`570`	`return None;`
`572`		`- } else {`
`573`		`- block_info`
`574`	`571`	`}`
	`572`	`+ block_info`
`575`	`573`	`}`
`576`	`574`	`Ok(None) => {`
`577`	`575`	`// We have not seen this block before. Why are we getting a response for it?`