chore: Apply Clippy lint vec_init_then_push

Author: jbencin

stackslib/src/chainstate/nakamoto/coordinator/tests.rs

@@ -3234,54 +3234,53 @@ fn test_stacks_on_burnchain_ops() {
         let (mut burn_ops, mut tenure_change, miner_key) =
             peer.begin_nakamoto_tenure(TenureChangeCause::BlockFound);
 
-        let mut new_burn_ops = vec![];
-        new_burn_ops.push(BlockstackOperationType::DelegateStx(DelegateStxOp {
-            sender: addr.clone(),
-            delegate_to: recipient_addr.clone(),
-            reward_addr: None,
-            delegated_ustx: 1,
-            until_burn_height: None,
-
-            // mocked
-            txid: Txid([i; 32]),
-            vtxindex: 11,
-            block_height: block_height + 1,
-            burn_header_hash: BurnchainHeaderHash([0x00; 32]),
-        }));
-        new_burn_ops.push(BlockstackOperationType::StackStx(StackStxOp {
-            sender: addr.clone(),
-            reward_addr: PoxAddress::Standard(
-                recipient_addr.clone(),
-                Some(AddressHashMode::SerializeP2PKH),
-            ),
-            stacked_ustx: 1,
-            num_cycles: 1,
-            signer_key: Some(StacksPublicKeyBuffer::from_public_key(
-                &StacksPublicKey::from_private(&recipient_private_key),
-            )),
-            max_amount: Some(1),
-            auth_id: Some(i as u32),
-
-            // mocked
-            txid: Txid([i | 0x80; 32]),
-            vtxindex: 12,
-            block_height: block_height + 1,
-            burn_header_hash: BurnchainHeaderHash([0x00; 32]),
-        }));
-        new_burn_ops.push(BlockstackOperationType::TransferStx(TransferStxOp {
-            sender: addr.clone(),
-            recipient: recipient_addr.clone(),
-            transfered_ustx: 1,
-            memo: vec![0x2],
-
-            // mocked
-            txid: Txid([i | 0x40; 32]),
-            vtxindex: 13,
-            block_height: block_height + 1,
-            burn_header_hash: BurnchainHeaderHash([0x00; 32]),
-        }));
-        new_burn_ops.push(BlockstackOperationType::VoteForAggregateKey(
-            VoteForAggregateKeyOp {
+        let mut new_burn_ops = vec![
+            BlockstackOperationType::DelegateStx(DelegateStxOp {
+                sender: addr.clone(),
+                delegate_to: recipient_addr.clone(),
+                reward_addr: None,
+                delegated_ustx: 1,
+                until_burn_height: None,
+
+                // mocked
+                txid: Txid([i; 32]),
+                vtxindex: 11,
+                block_height: block_height + 1,
+                burn_header_hash: BurnchainHeaderHash([0x00; 32]),
+            }),
+            BlockstackOperationType::StackStx(StackStxOp {
+                sender: addr.clone(),
+                reward_addr: PoxAddress::Standard(
+                    recipient_addr.clone(),
+                    Some(AddressHashMode::SerializeP2PKH),
+                ),
+                stacked_ustx: 1,
+                num_cycles: 1,
+                signer_key: Some(StacksPublicKeyBuffer::from_public_key(
+                    &StacksPublicKey::from_private(&recipient_private_key),
+                )),
+                max_amount: Some(1),
+                auth_id: Some(i as u32),
+
+                // mocked
+                txid: Txid([i | 0x80; 32]),
+                vtxindex: 12,
+                block_height: block_height + 1,
+                burn_header_hash: BurnchainHeaderHash([0x00; 32]),
+            }),
+            BlockstackOperationType::TransferStx(TransferStxOp {
+                sender: addr.clone(),
+                recipient: recipient_addr.clone(),
+                transfered_ustx: 1,
+                memo: vec![0x2],
+
+                // mocked
+                txid: Txid([i | 0x40; 32]),
+                vtxindex: 13,
+                block_height: block_height + 1,
+                burn_header_hash: BurnchainHeaderHash([0x00; 32]),
+            }),
+            BlockstackOperationType::VoteForAggregateKey(VoteForAggregateKeyOp {
                 sender: addr.clone(),
                 aggregate_key: StacksPublicKeyBuffer::from_public_key(
                     &StacksPublicKey::from_private(&agg_private_key),
@@ -3298,8 +3297,8 @@ fn test_stacks_on_burnchain_ops() {
                 vtxindex: 14,
                 block_height: block_height + 1,
                 burn_header_hash: BurnchainHeaderHash([0x00; 32]),
-            },
-        ));
+            }),
+        ];
 
         extra_burn_ops.push(new_burn_ops.clone());
         burn_ops.append(&mut new_burn_ops);

stackslib/src/net/api/tests/postblock_v3.rs

@@ -178,19 +178,12 @@ fn handle_req_accepted() {
         |_| true,
     );
     let next_block_id = next_block.block_id();
-    let mut requests = vec![];
-
-    // post the block
-    requests.push(StacksHttpRequest::new_post_block_v3(
-        addr.into(),
-        &next_block,
-    ));
-
-    // idempotent
-    requests.push(StacksHttpRequest::new_post_block_v3(
-        addr.into(),
-        &next_block,
-    ));
+    let requests = vec![
+        // post the block
+        StacksHttpRequest::new_post_block_v3(addr.into(), &next_block),
+        // idempotent
+        StacksHttpRequest::new_post_block_v3(addr.into(), &next_block),
+    ];
 
     let mut responses = rpc_test.run(requests);
 
@@ -229,29 +222,24 @@ fn handle_req_without_trailing_accepted() {
         |_| true,
     );
     let next_block_id = next_block.block_id();
-    let mut requests = vec![];
-
-    // post the block
-    requests.push(
+    let requests = vec![
+        // post the block
         StacksHttpRequest::new_for_peer(
             addr.into(),
             "POST".into(),
             path_without_slash.into(),
             HttpRequestContents::new().payload_stacks(&next_block),
         )
         .unwrap(),
-    );
-
-    // idempotent
-    requests.push(
+        // idempotent
         StacksHttpRequest::new_for_peer(
             addr.into(),
             "POST".into(),
             path_without_slash.into(),
             HttpRequestContents::new().payload_stacks(&next_block),
         )
         .unwrap(),
-    );
+    ];
     let mut responses = rpc_test.run(requests);
 
     let response = responses.remove(0);