fix: build transient error correctly

Author: obycode

stacks-signer/src/client/mod.rs

@@ -83,6 +83,9 @@ pub enum ClientError {
     /// Stacks node does not support a feature we need
     #[error("Stacks node does not support a required feature: {0}")]
     UnsupportedStacksFeature(String),
+    /// Invalid response from the stacks node
+    #[error("Invalid response from the stacks node: {0}")]
+    InvalidResponse(String),
 }
 
 /// Retry a function F with an exponential backoff and notification on transient failure

stacks-signer/src/runloop.rs

@@ -297,8 +297,9 @@ impl RunLoop {
                 if info.reward_cycle != block_reward_cycle {
                     // If the stacks-node is still processing the burn block, the /v2/pox endpoint
                     // may return the previous reward cycle. In this case, we should retry.
-                    return Err(backoff::Error::transient(err_msg!(
-                        "Received reward cycle info is not the new block's expected reward cycle. Try again."
+                    return Err(backoff::Error::transient(ClientError::InvalidResponse(
+                        "Received reward cycle info does not match the current burn block height."
+                            .to_string(),
                     )));
                 }
                 Ok(info)