Merge pull request #5040 from stacks-network/fix/multi-miner-fixes-jude

Fix/multi miner fixes jude

Author: jcnelson

.github/workflows/bitcoin-tests.yml

@@ -96,6 +96,7 @@ jobs:
           - tests::signer::v0::signer_set_rollover
           - tests::signer::v0::miner_forking
           - tests::signer::v0::reloads_signer_set_in
+          - tests::signer::v0::signers_broadcast_signed_blocks
           - tests::nakamoto_integrations::stack_stx_burn_op_integration_test
           - tests::nakamoto_integrations::check_block_heights
           - tests::nakamoto_integrations::clarity_burn_state

docs/rpc-endpoints.md

@@ -427,7 +427,7 @@ Determine whether a given trait is implemented within the specified contract (ei
 
 See OpenAPI [spec](./rpc/openapi.yaml) for details.
 
-### POST /v2/block_proposal
+### POST /v3/block_proposal
 
 Used by miner to validate a proposed Stacks block using JSON encoding.
 

libsigner/src/runloop.rs

@@ -53,7 +53,7 @@ pub trait SignerRunLoop<R: Send, CMD: Send, T: SignerEventTrait> {
         &mut self,
         event: Option<SignerEvent<T>>,
         cmd: Option<CMD>,
-        res: Sender<R>,
+        res: &Sender<R>,
     ) -> Option<R>;
 
     /// This is the main loop body for the signer. It continuously receives events from
@@ -70,6 +70,7 @@ pub trait SignerRunLoop<R: Send, CMD: Send, T: SignerEventTrait> {
         result_send: Sender<R>,
         mut event_stop_signaler: EVST,
     ) -> Option<R> {
+        info!("Signer runloop begin");
         loop {
             let poll_timeout = self.get_event_timeout();
             let next_event_opt = match event_recv.recv_timeout(poll_timeout) {
@@ -83,7 +84,7 @@ pub trait SignerRunLoop<R: Send, CMD: Send, T: SignerEventTrait> {
             // Do not block for commands
             let next_command_opt = command_recv.try_recv().ok();
             if let Some(final_state) =
-                self.run_one_pass(next_event_opt, next_command_opt, result_send.clone())
+                self.run_one_pass(next_event_opt, next_command_opt, &result_send)
             {
                 info!("Runloop exit; signaling event-receiver to stop");
                 event_stop_signaler.send();

libsigner/src/tests/mod.rs

@@ -76,7 +76,7 @@ impl<T: SignerEventTrait> SignerRunLoop<Vec<SignerEvent<T>>, Command, T> for Sim
         &mut self,
         event: Option<SignerEvent<T>>,
         _cmd: Option<Command>,
-        _res: Sender<Vec<SignerEvent<T>>>,
+        _res: &Sender<Vec<SignerEvent<T>>>,
     ) -> Option<Vec<SignerEvent<T>>> {
         debug!("Got event: {:?}", &event);
         if let Some(event) = event {

stacks-signer/src/client/mod.rs

@@ -570,6 +570,7 @@ pub(crate) mod tests {
             db_path: config.db_path.clone(),
             first_proposal_burn_block_timing: config.first_proposal_burn_block_timing,
             block_proposal_timeout: config.block_proposal_timeout,
+            broadcast_signed_blocks: true,
         }
     }
 

stacks-signer/src/client/stacks_client.rs

@@ -685,8 +685,13 @@ impl StacksClient {
     pub fn post_block(&self, block: &NakamotoBlock) -> Result<bool, ClientError> {
         let response = self
             .stacks_node_client
-            .post(format!("{}{}", self.http_origin, postblock_v3::PATH))
+            .post(format!(
+                "{}{}?broadcast=1",
+                self.http_origin,
+                postblock_v3::PATH
+            ))
             .header("Content-Type", "application/octet-stream")
+            .header(AUTHORIZATION, self.auth_password.clone())
             .body(block.serialize_to_vec())
             .send()?;
         if !response.status().is_success() {
@@ -789,7 +794,7 @@ impl StacksClient {
     }
 
     fn block_proposal_path(&self) -> String {
-        format!("{}/v2/block_proposal", self.http_origin)
+        format!("{}/v3/block_proposal", self.http_origin)
     }
 
     fn sortition_info_path(&self) -> String {
@@ -814,7 +819,7 @@ impl StacksClient {
     }
 
     fn reward_set_path(&self, reward_cycle: u64) -> String {
-        format!("{}/v2/stacker_set/{reward_cycle}", self.http_origin)
+        format!("{}/v3/stacker_set/{reward_cycle}", self.http_origin)
     }
 
     fn fees_transaction_path(&self) -> String {

stacks-signer/src/config.rs

@@ -157,6 +157,8 @@ pub struct SignerConfig {
     pub first_proposal_burn_block_timing: Duration,
     /// How much time to wait for a miner to propose a block following a sortition
     pub block_proposal_timeout: Duration,
+    /// Broadcast a block to the node if we gather enough signatures from other signers
+    pub broadcast_signed_blocks: bool,
 }
 
 /// The parsed configuration for the signer
@@ -201,6 +203,8 @@ pub struct GlobalConfig {
     pub first_proposal_burn_block_timing: Duration,
     /// How much time to wait for a miner to propose a block following a sortition
     pub block_proposal_timeout: Duration,
+    /// Broadcast a block to the node if we gather enough signatures from other signers
+    pub broadcast_signed_blocks: bool,
 }
 
 /// Internal struct for loading up the config file
@@ -357,6 +361,7 @@ impl TryFrom<RawConfigFile> for GlobalConfig {
             metrics_endpoint,
             first_proposal_burn_block_timing,
             block_proposal_timeout,
+            broadcast_signed_blocks: true,
         })
     }
 }

stacks-signer/src/lib.rs

@@ -69,7 +69,7 @@ pub trait Signer<T: SignerEventTrait>: Debug + Display {
         stacks_client: &StacksClient,
         sortition_state: &mut Option<SortitionsView>,
         event: Option<&SignerEvent<T>>,
-        res: Sender<Vec<SignerResult>>,
+        res: &Sender<Vec<SignerResult>>,
         current_reward_cycle: u64,
     );
     /// Process a command

stacks-signer/src/runloop.rs

@@ -335,6 +335,7 @@ impl<Signer: SignerTrait<T>, T: StacksMessageCodec + Clone + Send + Debug> RunLo
             max_tx_fee_ustx: self.config.max_tx_fee_ustx,
             db_path: self.config.db_path.clone(),
             block_proposal_timeout: self.config.block_proposal_timeout,
+            broadcast_signed_blocks: self.config.broadcast_signed_blocks,
         }))
     }
 
@@ -497,7 +498,7 @@ impl<Signer: SignerTrait<T>, T: StacksMessageCodec + Clone + Send + Debug>
         &mut self,
         event: Option<SignerEvent<T>>,
         cmd: Option<RunLoopCommand>,
-        res: Sender<Vec<SignerResult>>,
+        res: &Sender<Vec<SignerResult>>,
     ) -> Option<Vec<SignerResult>> {
         debug!(
             "Running one pass for the signer. state={:?}, cmd={cmd:?}, event={event:?}",
@@ -548,7 +549,7 @@ impl<Signer: SignerTrait<T>, T: StacksMessageCodec + Clone + Send + Debug>
                 &self.stacks_client,
                 &mut self.sortition_state,
                 event.as_ref(),
-                res.clone(),
+                res,
                 current_reward_cycle,
             );
             // After processing event, run the next command for each signer