fix: stacks-inspect commands work with default mainnet config again

Author: jbencin

stackslib/src/chainstate/nakamoto/mod.rs

@@ -2701,10 +2701,12 @@ impl NakamotoChainState {
         index_block_hash: &StacksBlockId,
     ) -> Result<Option<StacksHeaderInfo>, ChainstateError> {
         let sql = "SELECT * FROM block_headers WHERE index_block_hash = ?1";
+        println!("get_block_header_epoch2(): Looking for block {index_block_hash}");
         let result = query_row_panic(chainstate_conn, sql, &[&index_block_hash], || {
             "FATAL: multiple rows for the same block hash".to_string()
         })?;
 
+        println!("get_block_header_epoch2(): Found {result:?}");
         Ok(result)
     }
 
@@ -2713,6 +2715,7 @@ impl NakamotoChainState {
         chainstate_conn: &Connection,
         index_block_hash: &StacksBlockId,
     ) -> Result<Option<StacksHeaderInfo>, ChainstateError> {
+        println!("get_block_header(): Looking for block {index_block_hash}");
         if let Some(header) = Self::get_block_header_nakamoto(chainstate_conn, index_block_hash)? {
             return Ok(Some(header));
         }

stackslib/src/cli.rs

@@ -390,10 +390,8 @@ pub fn command_try_mine(argv: &[String], conf: Option<&Config>) {
         eprintln!("");
         eprintln!("Given a <working-dir>, try to ''mine'' an anchored block. This invokes the miner block");
         eprintln!("assembly, but does not attempt to broadcast a block commit. This is useful for determining");
-        eprintln!(
-            "what transactions a given chain state would include in an anchor block, or otherwise"
-        );
-        eprintln!("simulating a miner.");
+        eprintln!("what transactions a given chain state would include in an anchor block,");
+        eprintln!("or otherwise simulating a miner.");
         process::exit(1);
     };
 
@@ -418,16 +416,16 @@ pub fn command_try_mine(argv: &[String], conf: Option<&Config>) {
 
     let burnchain = conf.get_burnchain();
     let sort_db = SortitionDB::open(&sort_db_path, false, burnchain.pox_constants.clone())
-        .unwrap_or_else(|_| panic!("Failed to open {sort_db_path}"));
+        .unwrap_or_else(|e| panic!("Failed to open {sort_db_path}: {e}"));
     let (chain_state, _) = StacksChainState::open(
         conf.is_mainnet(),
         conf.burnchain.chain_id,
         &chain_state_path,
         None,
     )
-    .expect("Failed to open stacks chain state");
+    .unwrap_or_else(|e| panic!("Failed to open stacks chain state: {e}"));
     let chain_tip = SortitionDB::get_canonical_burn_chain_tip(sort_db.conn())
-        .expect("Failed to get sortition chain tip");
+        .unwrap_or_else(|e| panic!("Failed to get sortition chain tip: {e}"));
 
     let estimator = Box::new(UnitEstimator);
     let metric = Box::new(UnitMetric);
@@ -439,7 +437,7 @@ pub fn command_try_mine(argv: &[String], conf: Option<&Config>) {
         estimator,
         metric,
     )
-    .expect("Failed to open mempool db");
+    .unwrap_or_else(|e| panic!("Failed to open mempool db: {e}"));
 
     let header_tip = NakamotoChainState::get_canonical_block_header(chain_state.db(), &sort_db)
         .unwrap()
@@ -449,7 +447,7 @@ pub fn command_try_mine(argv: &[String], conf: Option<&Config>) {
         &header_tip.consensus_hash,
         &header_tip.anchored_header.block_hash(),
     )
-    .expect("Failed to load chain tip header info")
+    .unwrap_or_else(|e| panic!("Failed to load chain tip header info: {e}"))
     .expect("Failed to load chain tip header info");
 
     let sk = StacksPrivateKey::new();
@@ -482,7 +480,12 @@ pub fn command_try_mine(argv: &[String], conf: Option<&Config>) {
         &coinbase_tx,
         settings,
         None,
-        &Burnchain::new(&burnchain_path, "bitcoin", "main").unwrap(),
+        &Burnchain::new(
+            &burnchain_path,
+            &burnchain.chain_name,
+            &burnchain.network_name,
+        )
+        .unwrap(),
     );
 
     let stop = get_epoch_time_ms();
@@ -542,13 +545,13 @@ fn replay_staging_block(db_path: &str, index_block_hash_hex: &str, conf: Option<
     .unwrap();
 
     let burnchain = conf.get_burnchain();
-    let epochs = conf.burnchain.epochs.as_ref().expect("No Epochs found");
+    let epochs = conf.burnchain.get_epoch_list();
     let mut sortdb = SortitionDB::connect(
         &sort_db_path,
         burnchain.first_block_height,
         &burnchain.first_block_hash,
         u64::from(burnchain.first_block_timestamp),
-        epochs,
+        &epochs,
         burnchain.pox_constants.clone(),
         None,
         true,
@@ -620,13 +623,13 @@ fn replay_mock_mined_block(db_path: &str, block: AssembledAnchorBlock, conf: Opt
     .unwrap();
 
     let burnchain = conf.get_burnchain();
-    let epochs = conf.burnchain.epochs.as_ref().expect("No Epochs found");
+    let epochs = conf.burnchain.get_epoch_list();
     let mut sortdb = SortitionDB::connect(
         &sort_db_path,
         burnchain.first_block_height,
         &burnchain.first_block_hash,
         u64::from(burnchain.first_block_timestamp),
-        epochs,
+        &epochs,
         burnchain.pox_constants.clone(),
         None,
         true,
@@ -820,13 +823,13 @@ fn replay_naka_staging_block(db_path: &str, index_block_hash_hex: &str, conf: &C
     .unwrap();
 
     let burnchain = conf.get_burnchain();
-    let epochs = conf.burnchain.epochs.as_ref().expect("No Epochs found");
+    let epochs = conf.burnchain.get_epoch_list();
     let mut sortdb = SortitionDB::connect(
         &sort_db_path,
         burnchain.first_block_height,
         &burnchain.first_block_hash,
         u64::from(burnchain.first_block_timestamp),
-        epochs,
+        &epochs,
         burnchain.pox_constants.clone(),
         None,
         true,

stackslib/src/config/mod.rs

@@ -521,10 +521,7 @@ impl Config {
     }
 
     fn check_nakamoto_config(&self, burnchain: &Burnchain) {
-        let epochs = StacksEpoch::get_epochs(
-            self.burnchain.get_bitcoin_network().1,
-            self.burnchain.epochs.as_ref(),
-        );
+        let epochs = self.burnchain.get_epoch_list();
         let Some(epoch_30) = epochs.get(StacksEpochId::Epoch30) else {
             // no Epoch 3.0, so just return
             return;
@@ -1288,6 +1285,10 @@ impl BurnchainConfig {
             other => panic!("Invalid stacks-node mode: {other}"),
         }
     }
+
+    pub fn get_epoch_list(&self) -> EpochList<ExecutionCost> {
+        StacksEpoch::get_epochs(self.get_bitcoin_network().1, self.epochs.as_ref())
+    }
 }
 
 #[derive(Clone, Deserialize, Default, Debug)]

testnet/stacks-node/src/run_loop/boot_nakamoto.rs

@@ -22,9 +22,8 @@ use std::{fs, thread};
 use stacks::burnchains::Burnchain;
 use stacks::chainstate::burn::db::sortdb::SortitionDB;
 use stacks::chainstate::coordinator::comm::CoordinatorChannels;
-use stacks::core::StacksEpochExtension;
 use stacks::net::p2p::PeerNetwork;
-use stacks_common::types::{StacksEpoch, StacksEpochId};
+use stacks_common::types::StacksEpochId;
 
 use crate::event_dispatcher::EventDispatcher;
 use crate::globals::NeonGlobals;
@@ -233,10 +232,7 @@ impl BootRunLoop {
 
     fn reached_epoch_30_transition(config: &Config) -> Result<bool, String> {
         let burn_height = Self::get_burn_height(config)?;
-        let epochs = StacksEpoch::get_epochs(
-            config.burnchain.get_bitcoin_network().1,
-            config.burnchain.epochs.as_ref(),
-        );
+        let epochs = config.burnchain.get_epoch_list();
         let epoch_3 = epochs
             .get(StacksEpochId::Epoch30)
             .ok_or("No Epoch-3.0 defined")?;