Update tests/signer/commands for logging with info!

moodmosaic · moodmosaic · commit 604680729af3 · 2025-04-16T18:28:59.000+02:00
diff --git a/testnet/stacks-node/src/tests/signer/commands/block_commit.rs b/testnet/stacks-node/src/tests/signer/commands/block_commit.rs
@@ -16,15 +16,15 @@ impl SubmitBlockCommitSecondaryMinerCommand {
 
 impl Command<SignerTestState, SignerTestContext> for SubmitBlockCommitSecondaryMinerCommand {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Submitting block commit miner 2. Result: {:?}",
             state.is_secondary_miner_skip_commit_op
         );
         state.is_secondary_miner_skip_commit_op
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Submitting block commit miner 2");
+        info!("Applying: Submitting block commit miner 2");
 
         let (conf_1, _) = self.miners.lock().unwrap().get_node_configs();
         let burnchain = conf_1.get_burnchain();
@@ -58,15 +58,15 @@ impl SubmitBlockCommitPrimaryMinerCommand {
 
 impl Command<SignerTestState, SignerTestContext> for SubmitBlockCommitPrimaryMinerCommand {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Submitting block commit miner 1. Result: {:?}",
             state.is_primary_miner_skip_commit_op
         );
         state.is_primary_miner_skip_commit_op
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Submitting block commit miner 1");
+        info!("Applying: Submitting block commit miner 1");
 
         let (conf_1, _) = self.miners.lock().unwrap().get_node_configs();
         let burnchain = conf_1.get_burnchain();
diff --git a/testnet/stacks-node/src/tests/signer/commands/block_wait.rs b/testnet/stacks-node/src/tests/signer/commands/block_wait.rs
@@ -16,15 +16,15 @@ impl WaitForBlockFromMiner1Command {
 
 impl Command<SignerTestState, SignerTestContext> for WaitForBlockFromMiner1Command {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Waiting for Nakamoto block from miner 1. Result: {:?}",
             !state.mining_stalled
         );
         !state.mining_stalled
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Waiting for Nakamoto block from miner 1");
+        info!("Applying: Waiting for Nakamoto block from miner 1");
 
         let miners_arc = self.miners.clone();
 
@@ -40,7 +40,7 @@ impl Command<SignerTestState, SignerTestContext> for WaitForBlockFromMiner1Comma
             .load(Ordering::SeqCst);
         let expected_height = last_confirmed_height + 1;
 
-        println!(
+        info!(
             "Waiting for Nakamoto block {} pushed by miner 1",
             expected_height
         );
@@ -74,15 +74,15 @@ impl WaitForBlockFromMiner2Command {
 
 impl Command<SignerTestState, SignerTestContext> for WaitForBlockFromMiner2Command {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Waiting for Nakamoto block from miner 2. Result: {:?}",
             !state.mining_stalled
         );
         !state.mining_stalled
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Waiting for Nakamoto block from miner 2");
+        info!("Applying: Waiting for Nakamoto block from miner 2");
 
         let miners_arc = self.miners.clone();
 
@@ -98,7 +98,7 @@ impl Command<SignerTestState, SignerTestContext> for WaitForBlockFromMiner2Comma
             .load(Ordering::SeqCst);
         let expected_stacks_height = last_confirmed_height + 1;
 
-        println!(
+        info!(
             "Waiting for Nakamoto block {} pushed by miner 2",
             expected_stacks_height
         );
diff --git a/testnet/stacks-node/src/tests/signer/commands/boot.rs b/testnet/stacks-node/src/tests/signer/commands/boot.rs
@@ -16,15 +16,15 @@ impl BootToEpoch3 {
 
 impl Command<SignerTestState, SignerTestContext> for BootToEpoch3 {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Booting miners to Nakamoto. Result: {:?}",
             !state.is_booted_to_nakamoto
         );
         !state.is_booted_to_nakamoto
     }
 
     fn apply(&self, state: &mut SignerTestState) {
-        println!("Applying: Booting miners to Nakamoto");
+        info!("Applying: Booting miners to Nakamoto");
 
         self.miners.lock().unwrap().boot_to_epoch_3();
 
diff --git a/testnet/stacks-node/src/tests/signer/commands/commit_ops.rs b/testnet/stacks-node/src/tests/signer/commands/commit_ops.rs
@@ -18,15 +18,15 @@ impl SkipCommitOpPrimaryMiner {
 
 impl Command<SignerTestState, SignerTestContext> for SkipCommitOpPrimaryMiner {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Skipping commit operations for miner 1. Result: {:?}",
             !state.is_primary_miner_skip_commit_op
         );
         !state.is_primary_miner_skip_commit_op
     }
 
     fn apply(&self, state: &mut SignerTestState) {
-        println!("Applying: Skipping commit operations for miner 1");
+        info!("Applying: Skipping commit operations for miner 1");
 
         self.miner_1_skip_commit_flag.set(true);
 
@@ -60,15 +60,15 @@ impl SkipCommitOpSecondaryMiner {
 
 impl Command<SignerTestState, SignerTestContext> for SkipCommitOpSecondaryMiner {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Skipping commit operations for miner 2. Result: {:?}",
             !state.is_secondary_miner_skip_commit_op
         );
         !state.is_secondary_miner_skip_commit_op
     }
 
     fn apply(&self, state: &mut SignerTestState) {
-        println!("Applying: Skipping commit operations for miner 2");
+        info!("Applying: Skipping commit operations for miner 2");
 
         self.miner_2_skip_commit_flag.set(true);
 
diff --git a/testnet/stacks-node/src/tests/signer/commands/mining.rs b/testnet/stacks-node/src/tests/signer/commands/mining.rs
@@ -22,15 +22,15 @@ impl Command<SignerTestState, SignerTestContext>
     for MineBitcoinBlockTenureChangePrimaryMinerCommand
 {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Miner 1 mining Bitcoin block and tenure change tx. Result: {:?}",
             state.is_booted_to_nakamoto
         );
         state.is_booted_to_nakamoto
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Miner 1 mining Bitcoin block and tenure change tx");
+        info!("Applying: Miner 1 mining Bitcoin block and tenure change tx");
 
         let (stacks_height_before, conf_1, miner_pk_1) = {
             let mut miners = self.miners.lock().unwrap();
@@ -48,7 +48,7 @@ impl Command<SignerTestState, SignerTestContext>
             (stacks_height_before, conf_1, miner_pk_1)
         };
 
-        println!(
+        info!(
             "Waiting for Nakamoto block {} pushed by miner 1",
             stacks_height_before + 1
         );
@@ -96,15 +96,15 @@ impl Command<SignerTestState, SignerTestContext>
     for MineBitcoinBlockTenureChangeSecondaryMinerCommand
 {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Miner 2 mining Bitcoin block and tenure change tx. Result: {:?}",
             state.is_booted_to_nakamoto
         );
         state.is_booted_to_nakamoto
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Miner 2 mining Bitcoin block and tenure change tx");
+        info!("Applying: Miner 2 mining Bitcoin block and tenure change tx");
 
         let stacks_height_before = self.miners.lock().unwrap().get_peer_stacks_tip_height();
 
@@ -119,7 +119,7 @@ impl Command<SignerTestState, SignerTestContext>
 
         let (_, miner_pk_2) = self.miners.lock().unwrap().get_miner_public_keys();
 
-        println!(
+        info!(
             "Waiting for Nakamoto block {} pushed by miner 2",
             stacks_height_before + 1
         );
diff --git a/testnet/stacks-node/src/tests/signer/commands/shutdown.rs b/testnet/stacks-node/src/tests/signer/commands/shutdown.rs
@@ -16,12 +16,12 @@ impl ShutdownMinersCommand {
 
 impl Command<SignerTestState, SignerTestContext> for ShutdownMinersCommand {
     fn check(&self, _state: &SignerTestState) -> bool {
-        println!("Checking: Shutting down miners. Result: {:?}", true);
+        info!("Checking: Shutting down miners. Result: {:?}", true);
         true
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Shutting down miners");
+        info!("Applying: Shutting down miners");
 
         if let Ok(miners_arc) = Arc::try_unwrap(self.miners.clone()) {
             if let Ok(miners) = miners_arc.into_inner() {
diff --git a/testnet/stacks-node/src/tests/signer/commands/stalling.rs b/testnet/stacks-node/src/tests/signer/commands/stalling.rs
@@ -7,15 +7,15 @@ pub struct StallMiningCommand;
 
 impl Command<SignerTestState, SignerTestContext> for StallMiningCommand {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Stalling mining. Result: {:?}",
             !state.mining_stalled
         );
         !state.mining_stalled
     }
 
     fn apply(&self, state: &mut SignerTestState) {
-        println!("Applying: Stalling mining");
+        info!("Applying: Stalling mining");
         crate::tests::signer::v0::test_mine_stall_set(true);
         state.mining_stalled = true;
     }
@@ -35,15 +35,15 @@ pub struct RecoverFromStallCommand;
 
 impl Command<SignerTestState, SignerTestContext> for RecoverFromStallCommand {
     fn check(&self, state: &SignerTestState) -> bool {
-        println!(
+        info!(
             "Checking: Recovering from mining stall. Result: {:?}",
             state.mining_stalled
         );
         state.mining_stalled
     }
 
     fn apply(&self, state: &mut SignerTestState) {
-        println!("Applying: Recovering from mining stall");
+        info!("Applying: Recovering from mining stall");
         crate::tests::signer::v0::test_mine_stall_set(false);
         state.mining_stalled = false;
     }
diff --git a/testnet/stacks-node/src/tests/signer/commands/tenure.rs b/testnet/stacks-node/src/tests/signer/commands/tenure.rs
@@ -20,12 +20,12 @@ impl MineTenureCommand {
 
 impl Command<SignerTestState, SignerTestContext> for MineTenureCommand {
     fn check(&self, _state: &SignerTestState) -> bool {
-        println!("Checking: Mining tenure. Result: {:?}", true);
+        info!("Checking: Mining tenure. Result: {:?}", true);
         true
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!(
+        info!(
             "Applying: Mining tenure and waiting for it for {:?} seconds",
             self.timeout_secs
         );
diff --git a/testnet/stacks-node/src/tests/signer/commands/transfer.rs b/testnet/stacks-node/src/tests/signer/commands/transfer.rs
@@ -16,12 +16,12 @@ impl SendTransferTxCommand {
 
 impl Command<SignerTestState, SignerTestContext> for SendTransferTxCommand {
     fn check(&self, _state: &SignerTestState) -> bool {
-        println!("Checking: Sending transfer tx. Result: {:?}", true);
+        info!("Checking: Sending transfer tx. Result: {:?}", true);
         true
     }
 
     fn apply(&self, _state: &mut SignerTestState) {
-        println!("Applying: Sending transfer tx");
+        info!("Applying: Sending transfer tx");
 
         self.miners.lock().unwrap().send_transfer_tx();
     }

Original file line number	Diff line number	Diff line change
`@@ -16,12 +16,12 @@ impl SendTransferTxCommand {`
`16`	`16`
`17`	`17`	`impl Command<SignerTestState, SignerTestContext> for SendTransferTxCommand {`
`18`	`18`	`fn check(&self, _state: &SignerTestState) -> bool {`
`19`		`- println!("Checking: Sending transfer tx. Result: {:?}", true);`
	`19`	`+ info!("Checking: Sending transfer tx. Result: {:?}", true);`
`20`	`20`	`true`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`fn apply(&self, _state: &mut SignerTestState) {`
`24`		`- println!("Applying: Sending transfer tx");`
	`24`	`+ info!("Applying: Sending transfer tx");`
`25`	`25`
`26`	`26`	`self.miners.lock().unwrap().send_transfer_tx();`
`27`	`27`	`}`