Fix clippy::unnecessary_fold throughout stacks core

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jferrant

stackslib/src/chainstate/burn/operations/leader_block_commit.rs

@@ -467,9 +467,7 @@ impl LeaderBlockCommitOp {
     pub fn all_outputs_burn(&self) -> bool {
         self.commit_outs
             .iter()
-            .fold(true, |previous_is_burn, output_addr| {
-                previous_is_burn && output_addr.is_burn()
-            })
+            .all(|output_addr| output_addr.is_burn())
     }
 
     pub fn spent_txid(&self) -> &Txid {

stackslib/src/net/relay.rs

@@ -450,7 +450,7 @@ impl RelayerStats {
         warmup_threshold: usize,
     ) -> HashMap<NeighborKey, usize> {
         let mut dup_counts = self.count_relay_dups(msg);
-        let mut dup_total = dup_counts.values().fold(0, |t, s| t + s);
+        let mut dup_total = dup_counts.values().sum::<usize>();
 
         if dup_total < warmup_threshold {
             // don't make inferences on small samples for total duplicates.
@@ -484,7 +484,7 @@ impl RelayerStats {
         neighbors: &[NeighborKey],
     ) -> Result<HashMap<NeighborKey, usize>, net_error> {
         let asn_counts = RelayerStats::count_ASNs(peerdb.conn(), neighbors)?;
-        let asn_total = asn_counts.values().fold(0, |t, s| t + s);
+        let asn_total = asn_counts.values().sum::<usize>();
 
         let mut ret = HashMap::new();
 
@@ -510,7 +510,7 @@ impl RelayerStats {
         let mut ret = HashSet::new();
         let mut rng = thread_rng();
 
-        let mut norm = rankings.values().fold(0, |t, s| t + s);
+        let mut norm = rankings.values().sum::<usize>();
         let mut rankings_vec: Vec<(NeighborKey, usize)> = rankings.into_iter().collect();
         let mut sampled = 0;