crc: fix list_unspent maximum_count unlimited default, #6250

Author: fdefelici

stacks-node/src/burnchains/rpc/bitcoin_rpc_client/mod.rs

@@ -491,7 +491,7 @@ impl BitcoinRpcClient {
     /// * `addresses` - Optional list of addresses to filter UTXOs by (Default: no filtering).
     /// * `include_unsafe` - Whether to include UTXOs from unconfirmed unsafe transactions (Default: `true`).
     /// * `minimum_amount` - Minimum amount in satoshis (internally converted to BTC string to preserve full precision) a UTXO must have to be included (Default: 0).
-    /// * `maximum_count` - Maximum number of UTXOs to return. Use `None` for effectively unlimited (Default: 9.999.999).
+    /// * `maximum_count` - Maximum number of UTXOs to return. Use `None` for effectively 'unlimited' (Default: 0).
     ///
     /// # Returns
     /// A Vec<[`ListUnspentResponse`]> containing the matching UTXOs.
@@ -513,7 +513,7 @@ impl BitcoinRpcClient {
         let addresses = addresses.unwrap_or(&[]);
         let include_unsafe = include_unsafe.unwrap_or(true);
         let minimum_amount = minimum_amount.unwrap_or(0);
-        let maximum_count = maximum_count.unwrap_or(9_999_999);
+        let maximum_count = maximum_count.unwrap_or(0);
 
         let addr_as_strings: Vec<String> = addresses.iter().map(|addr| addr.to_string()).collect();
         let min_amount_btc_str = convert_sat_to_btc_string(minimum_amount);

stacks-node/src/tests/bitcoin_rpc_integrations.rs

@@ -322,7 +322,31 @@ fn test_generate_to_address_ok() {
 
 #[ignore]
 #[test]
-fn test_list_unspent_one_address_ok() {
+fn test_list_unspent_empty_with_empty_wallet() {
+    if env::var("BITCOIND_TEST") != Ok("1".into()) {
+        return;
+    }
+
+    let mut config = utils::create_stx_config();
+    config.burnchain.wallet_name = "my_wallet".to_string();
+
+    let mut btcd_controller = BitcoinCoreController::new(config.clone());
+    btcd_controller
+        .start_bitcoind()
+        .expect("bitcoind should be started!");
+
+    let client = BitcoinRpcClient::from_stx_config(&config).expect("Client creation ok!");
+    client.create_wallet("my_wallet", Some(false)).expect("OK");
+
+    let utxos = client
+        .list_unspent(None, None, None, None, None, None)
+        .expect("all list_unspent should be ok!");
+    assert_eq!(0, utxos.len());
+}
+
+#[ignore]
+#[test]
+fn test_list_unspent_with_defaults() {
     if env::var("BITCOIND_TEST") != Ok("1".into()) {
         return;
     }
@@ -337,14 +361,41 @@ fn test_list_unspent_one_address_ok() {
 
     let client = BitcoinRpcClient::from_stx_config(&config).expect("Client creation ok!");
     client.create_wallet("my_wallet", Some(false)).expect("OK");
+
     let address = client
         .get_new_address(None, Some(AddressType::Legacy))
         .expect("Should work!");
 
-    let no_utxos = client
-        .list_unspent(None, None, None, Some(false), Some(1), Some(10))
-        .expect("list_unspent empty should be ok!");
-    assert_eq!(0, no_utxos.len());
+    _ = client
+        .generate_to_address(102, &address)
+        .expect("generate to address ok!");
+
+    let utxos = client
+        .list_unspent(None, None, None, None, None, None)
+        .expect("all list_unspent should be ok!");
+    assert_eq!(2, utxos.len());
+}
+
+#[ignore]
+#[test]
+fn test_list_unspent_one_address_ok() {
+    if env::var("BITCOIND_TEST") != Ok("1".into()) {
+        return;
+    }
+
+    let mut config = utils::create_stx_config();
+    config.burnchain.wallet_name = "my_wallet".to_string();
+
+    let mut btcd_controller = BitcoinCoreController::new(config.clone());
+    btcd_controller
+        .start_bitcoind()
+        .expect("bitcoind should be started!");
+
+    let client = BitcoinRpcClient::from_stx_config(&config).expect("Client creation ok!");
+    client.create_wallet("my_wallet", Some(false)).expect("OK");
+    let address = client
+        .get_new_address(None, Some(AddressType::Legacy))
+        .expect("Should work!");
 
     _ = client
         .generate_to_address(102, &address)
@@ -395,10 +446,10 @@ fn test_list_unspent_two_addresses_ok() {
 
     let client = BitcoinRpcClient::from_stx_config(&config).expect("Client creation ok!");
     client.create_wallet("my_wallet", Some(false)).expect("OK");
+
     let address1 = client
         .get_new_address(None, Some(AddressType::Legacy))
         .expect("address 1 ok!");
-
     let address2 = client
         .get_new_address(None, Some(AddressType::Legacy))
         .expect("address 2 ok!");