chore: PR feedback

Author: jcnelson

clarity/src/vm/analysis/type_checker/v2_1/tests/mod.rs

@@ -48,7 +48,6 @@ pub mod contracts;
 
 /// Backwards-compatibility shim for type_checker tests. Runs at latest Clarity version.
 pub fn mem_type_check(exp: &str) -> CheckResult<(Option<TypeSignature>, ContractAnalysis)> {
-    // TODO (question for reviewers): This uses Clarity 3 with Epoch 2.1.  Is this a problem?
     mem_run_analysis(
         exp,
         crate::vm::ClarityVersion::latest(),

stacks-common/src/types/mod.rs

@@ -215,7 +215,7 @@ impl CoinbaseInterval {
         intervals: &[CoinbaseInterval],
         effective_height: u64,
     ) -> u128 {
-        if intervals.len() == 0 {
+        if intervals.is_empty() {
             return 0;
         }
         if intervals.len() == 1 {

stackslib/src/chainstate/stacks/db/blocks.rs

@@ -4109,7 +4109,7 @@ impl StacksChainState {
                         current_epoch = StacksEpochId::Epoch31;
                     }
                     StacksEpochId::Epoch31 => {
-                        panic!("No defined transition from Epoch30 forward")
+                        panic!("No defined transition from Epoch31 forward")
                     }
                 }
             }