chore: rename prometheus conflict metric about miner view, #5918

Author: fdefelici

stacks-signer/src/monitoring/mod.rs

@@ -42,8 +42,8 @@ SignerAgreementStateConflict {
     BurnBlockDelay("burn_block_delay"),
     /// Waiting for stacks block propagation to be aligned with the signer set
     StacksBlockDelay("stacks_block_delay"),
-    /// Not allowing reorg to a new miner
-    ReorgDisallowed("reorg_disallowed"),
+    /// No agreement on miner view with the signer set
+    MinerView("miner_view"),
 });
 
 /// Actions for updating metrics

stacks-signer/src/monitoring/prometheus.rs

@@ -87,7 +87,7 @@ lazy_static! {
 
     pub static ref SIGNER_AGREEMENT_STATE_CONFLICTS: IntCounterVec = register_int_counter_vec!(
         "stacks_signer_agreement_state_conflicts",
-        "The number of state machine conflicts in signer agreement protocol. `conflict` can be one of: 'burn_block_delay', 'stacks_block_delay', 'reorg_disallowed'",
+        "The number of state machine conflicts in signer agreement protocol. `conflict` can be one of: 'burn_block_delay', 'stacks_block_delay', 'miner_view'",
         &["conflict"]
     ).unwrap();
 

stacks-signer/src/v0/signer_state.rs

@@ -214,7 +214,7 @@ impl GlobalStateEvaluator {
             }
         }
         crate::monitoring::actions::increment_signer_agreement_state_conflict(
-            crate::monitoring::SignerAgreementStateConflict::ReorgDisallowed,
+            crate::monitoring::SignerAgreementStateConflict::MinerView,
         );
         None
     }