crc: improve errors message

Author: federico-stacks

clarity-types/src/errors/analysis.rs

@@ -1066,7 +1066,7 @@ impl From<CommonCheckErrorKind> for RuntimeCheckErrorKind {
             }
             CommonCheckErrorKind::TooManyFunctionParameters(found, allowed) => {
                 RuntimeCheckErrorKind::ExpectsAcceptable(format!(
-                    "Too many function params: {found} allowed {allowed}"
+                    "Too many function params: found {found}, allowed {allowed}"
                 ))
             }
             CommonCheckErrorKind::ExpectedName => {
@@ -1100,7 +1100,7 @@ impl From<CommonCheckErrorKind> for RuntimeCheckErrorKind {
             }
             CommonCheckErrorKind::TraitTooManyMethods(found, allowed) => {
                 RuntimeCheckErrorKind::ExpectsAcceptable(format!(
-                    "Trait too many methods: {found} allowed {allowed}"
+                    "Trait too many methods: found {found}, allowed {allowed}"
                 ))
             }
             CommonCheckErrorKind::DefineTraitBadSignature => {

clarity/src/vm/functions/define.rs

@@ -603,7 +603,7 @@ mod test {
 
         assert_eq!(
             VmExecutionError::RuntimeCheck(RuntimeCheckErrorKind::ExpectsAcceptable(
-                "Too many function params: 257 allowed 256".to_string()
+                "Too many function params: found 257, allowed 256".to_string()
             )),
             err
         );

clarity/src/vm/functions/post_conditions.rs

@@ -260,7 +260,7 @@ pub fn special_restrict_assets(
     let allowance_list = args[1]
         .match_list()
         .ok_or(RuntimeCheckErrorKind::ExpectsAcceptable(
-            "Expected list of allowances: restrict-assets? 2".to_string(),
+            "Expected list of allowances: for restrict-assets? as argument 2".to_string(),
         ))?;
     let body_exprs = &args[2..];
 
@@ -274,7 +274,7 @@ pub fn special_restrict_assets(
 
     if allowance_len > MAX_ALLOWANCES {
         return Err(RuntimeCheckErrorKind::ExpectsAcceptable(format!(
-            "Too many allowances: {allowance_len} allowed {MAX_ALLOWANCES}"
+            "Too many allowances: got {allowance_len}, allowed {MAX_ALLOWANCES}"
         ))
         .into());
     }
@@ -349,7 +349,7 @@ pub fn special_as_contract(
     let allowance_list = args[0]
         .match_list()
         .ok_or(RuntimeCheckErrorKind::ExpectsAcceptable(
-            "Expected list of allowances: as-contract? 1".to_string(),
+            "Expected list of allowances: for as-contract? as argument 1".to_string(),
         ))?;
     let body_exprs = &args[1..];
 

clarity/src/vm/functions/sequences.rs

@@ -351,7 +351,7 @@ pub fn special_concat_v205(
             runtime_cost(ClarityCostFunction::Concat, env, 1)?;
             return Err(RuntimeCheckErrorKind::ExpectsAcceptable(format!(
                 "Expected sequence: {}",
-                TypeSignature::NoType
+                TypeSignature::type_of(&wrapped_seq)?,
             ))
             .into());
         }

clarity/src/vm/tests/post_conditions.rs

@@ -1665,7 +1665,7 @@ fn restrict_assets_too_many_allowances() {
     );
     let max_allowances_err: ClarityEvalError =
         VmExecutionError::RuntimeCheck(RuntimeCheckErrorKind::ExpectsAcceptable(format!(
-            "Too many allowances: {} allowed {MAX_ALLOWANCES}",
+            "Too many allowances: got {}, allowed {MAX_ALLOWANCES}",
             MAX_ALLOWANCES + 1
         )))
         .into();
@@ -1739,7 +1739,7 @@ fn restrict_assets_expected_list_of_allowances() {
     "#;
     let expected_error: ClarityEvalError =
         VmExecutionError::RuntimeCheck(RuntimeCheckErrorKind::ExpectsAcceptable(
-            "Expected list of allowances: restrict-assets? 2".to_string(),
+            "Expected list of allowances: for restrict-assets? as argument 2".to_string(),
         ))
         .into();
 
@@ -1762,7 +1762,7 @@ fn as_contract_expected_list_of_allowances() {
     // The argument is `u42` (not a list), so we expect this error
     let expected_error: ClarityEvalError =
         VmExecutionError::RuntimeCheck(RuntimeCheckErrorKind::ExpectsAcceptable(
-            "Expected list of allowances: as-contract? 1".to_string(),
+            "Expected list of allowances: for as-contract? as argument 1".to_string(),
         ))
         .into();