move logs to add/remove neighbor to p2p session

Author: ASuciuX

stackslib/src/net/neighbors/walk.rs

@@ -1086,10 +1086,6 @@ impl<DB: NeighborWalkDB, NC: NeighborComms> NeighborWalk<DB, NC> {
 
         if new {
             // neighbor was new
-            info!(
-                "New neighbor added: public key: {:?} address: {:?}",
-                naddr.public_key_hash, naddr.addrbytes
-            );
             self.new_frontier
                 .insert(neighbor.addr.clone(), neighbor.clone());
         } else {
@@ -1805,11 +1801,6 @@ impl<DB: NeighborWalkDB, NC: NeighborComms> NeighborWalk<DB, NC> {
                 }
                 StacksMessageType::Nack(ref data) => {
                     // evict
-                    info!(
-                        "Dropping neighbor {:?} Reason: will Evict message: {:?}",
-                        nkey.public_key_hash,
-                        message.get_message_name()
-                    );
                     debug!(
                         "{:?}: Neighbor {:?} NACK'ed Handshake with code {:?}; will evict",
                         network.get_local_peer(),
@@ -1821,7 +1812,6 @@ impl<DB: NeighborWalkDB, NC: NeighborComms> NeighborWalk<DB, NC> {
                 }
                 _ => {
                     // unexpected reply -- this peer is misbehaving and should be replaced
-                    info!("Dropping neighbor {:?} Reason: unexpected reply {:?} this peer is misbehaving and should be replaced", nkey.public_key_hash, message.get_message_name());
                     debug!("{:?}: Neighbor {:?} replied an out-of-sequence message (type {}); will replace", network.get_local_peer(), &nkey, message.get_message_name());
                     self.comms.add_broken(network, &nkey);
                     continue;

stackslib/src/net/p2p.rs

@@ -1822,7 +1822,12 @@ impl PeerNetwork {
         };
 
         match self.can_register_peer(&neighbor_key, outbound) {
-            Ok(_) => {}
+            Ok(_) => {
+                info!(
+                    "Neighbor accepted! public key: {:?} address: {:?}",
+                    pubkey_opt, neighbor_key.addrbytes
+                );
+            }
             Err(e) => {
                 debug!(
                     "{:?}: Could not register peer {:?}: {:?}",
@@ -1917,6 +1922,10 @@ impl PeerNetwork {
         for (nk, pubkh) in nk_remove.into_iter() {
             // remove event state
             self.events.remove(&nk);
+            info!(
+                "Dropping neighbor! event id: {:?} public address: {:?} public key: {:?}",
+                event_id, pubkh, nk.addrbytes
+            );
 
             // remove inventory state
             if let Some(inv_state) = self.inv_state.as_mut() {