Fix get_latest_block_proposal function to return an err if the list is empty

jferrant · jferrant · commit 9475758eee23 · 2025-01-13T15:31:32.000-08:00
Signed-off-by: Jacinta Ferrant &lt;jacinta@trustmachines.co&gt;
diff --git a/testnet/stacks-node/src/tests/nakamoto_integrations.rs b/testnet/stacks-node/src/tests/nakamoto_integrations.rs
@@ -457,7 +457,9 @@ pub fn get_latest_block_proposal(
         info!("Consider block"; "signer_sighash" => %b.header.signer_signature_hash(), "is_latest_sortition" => is_latest, "chain_height" => b.header.chain_length);
     }
 
-    let (proposed_block, miner_addr, _) = proposed_blocks.pop().unwrap();
+    let Some((proposed_block, miner_addr, _)) = proposed_blocks.pop() else {
+        return Err("No block proposals found".into());
+    };
 
     let pubkey = StacksPublicKey::recover_to_pubkey(
         proposed_block.header.miner_signature_hash().as_bytes(),

Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,9 @@ pub fn get_latest_block_proposal(`
`457`	`457`	`info!("Consider block"; "signer_sighash" => %b.header.signer_signature_hash(), "is_latest_sortition" => is_latest, "chain_height" => b.header.chain_length);`
`458`	`458`	`}`
`459`	`459`
`460`		`- let (proposed_block, miner_addr, _) = proposed_blocks.pop().unwrap();`
	`460`	`+ let Some((proposed_block, miner_addr, _)) = proposed_blocks.pop() else {`
	`461`	`+ return Err("No block proposals found".into());`
	`462`	`+ };`
`461`	`463`
`462`	`464`	`let pubkey = StacksPublicKey::recover_to_pubkey(`
`463`	`465`	`proposed_block.header.miner_signature_hash().as_bytes(),`