fix: ongoing commit logic + better error messages

* correct the ongoing commit logic (and RBF handling) in bitcoin tx submissions
* better error messages from send_http_request

Author: kantai

stackslib/src/net/httpcore.rs

@@ -1953,15 +1953,16 @@ pub fn send_http_request(
     // Step 5: decode the HTTP message and return it if it's not an error.
     let response_data = match response {
         StacksHttpMessage::Response(response_data) => response_data,
-        StacksHttpMessage::Error(path, response) => {
+        StacksHttpMessage::Error(_path, response) => {
+            let verb = &request.preamble().verb;
+            let path = &request.preamble().path_and_query_str;
+            let resp_status_code = response.preamble().status_code;
+            let resp_body = response.body();
             return Err(io::Error::new(
                 io::ErrorKind::Other,
                 format!(
-                    "Request did not succeed ({} != 200). Path: '{}'",
-                    response.preamble().status_code,
-                    &path
-                )
-                .as_str(),
+                    "HTTP '{verb} {path}' did not succeed ({resp_status_code} != 200). Response body = {resp_body:?}"
+                ),
             ));
         }
         _ => {

testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs

@@ -1662,7 +1662,10 @@ impl BitcoinRegtestController {
             )
         } else {
             // Case 2) ii): Attempt to RBF
-            info!("Attempt to replace by fee an outdated leader block commit");
+            info!(
+                "Attempt to replace by fee an outdated leader block commit";
+                "ongoing_txids" => ?ongoing_op.txids
+            );
             self.send_block_commit_operation(
                 epoch_id,
                 payload,
@@ -1674,7 +1677,7 @@ impl BitcoinRegtestController {
             )
         };
 
-        if res.is_ok() {
+        if res.is_err() {
             self.ongoing_block_commit = Some(ongoing_op);
         }