CRC: remove unnecessary brackets and store total_requests_sent as a local var

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jferrant

stackslib/src/net/atlas/download.rs

@@ -1314,11 +1314,11 @@ impl ReliabilityReport {
     }
 
     pub fn score(&self) -> u32 {
-        if self.total_requests_sent == 0 {
-            return 0;
+        let n = self.total_requests_sent;
+        if n == 0 {
+            return n;
         }
-        self.total_requests_success * 1000 / (self.total_requests_sent * 1000)
-            + self.total_requests_sent
+        self.total_requests_success * 1000 / (n * 1000) + n
     }
 }
 

stackslib/src/util_lib/strings.rs

@@ -207,7 +207,7 @@ impl StacksString {
         // This is 0x20 through 0x7e, inclusive, as well as '\t' and '\n'
         // TODO: DRY up with vm::representations
         for c in s.as_bytes().iter() {
-            if (*c < 0x20 && *c != (b'\t') && *c != (b'\n')) || (*c > 0x7e) {
+            if (*c < 0x20 && *c != b'\t' && *c != b'\n') || *c > 0x7e {
                 return false;
             }
         }