chore: address PR feedback

Author: obycode

.github/workflows/bitcoin-tests.yml

@@ -70,6 +70,7 @@ jobs:
           - tests::neon_integrations::use_latest_tip_integration_test
           - tests::neon_integrations::min_txs
           - tests::should_succeed_handling_malformed_and_valid_txs
+          - tests::neon_integrations::bitcoin_reorg_flap
     steps:
       ## Setup test environment
       - name: Setup Test Environment

stackslib/src/burnchains/bitcoin/indexer.rs

@@ -837,10 +837,9 @@ impl BitcoinIndexer {
                 }
             } else {
                 // ignore the reorg
-                test_debug!(
+                debug!(
                     "Reorg chain does not overtake original Bitcoin chain ({} >= {})",
-                    orig_total_work,
-                    reorg_total_work
+                    orig_total_work, reorg_total_work
                 );
                 new_tip = orig_spv_client.get_headers_height()?;
             }

stackslib/src/burnchains/db.rs

@@ -312,7 +312,7 @@ impl<'a> BurnchainDBTransaction<'a> {
     fn store_burnchain_db_entry(
         &self,
         header: &BurnchainBlockHeader,
-    ) -> Result<i64, BurnchainError> {
+    ) -> Result<(), BurnchainError> {
         let sql = "INSERT OR IGNORE INTO burnchain_db_block_headers
                    (block_height, block_hash, parent_block_hash, num_txs, timestamp)
                    VALUES (?, ?, ?, ?, ?)";
@@ -330,11 +330,8 @@ impl<'a> BurnchainDBTransaction<'a> {
                 "Duplicate entry for block_hash: {}, insert operation ignored.",
                 header.block_hash
             );
-            Ok(-1)
-        } else {
-            // A new row was inserted successfully
-            Ok(self.sql_tx.last_insert_rowid())
         }
+        Ok(())
     }
 
     /// Add an affirmation map into the database.  Returns the affirmation map ID.