Skip to content

Commit abff263

Browse files
committed
Fix bad change to database call to get signed blocks in a tenure
Signed-off-by: Jacinta Ferrant <[email protected]>
1 parent c3c0392 commit abff263

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

stacks-signer/src/signerdb.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,8 @@ impl SignerDb {
774774

775775
/// Return whether there was signed block in a tenure (identified by its consensus hash)
776776
pub fn has_signed_block_in_tenure(&self, tenure: &ConsensusHash) -> Result<bool, DBError> {
777-
let query = "SELECT block_info FROM blocks WHERE consensus_hash = ? AND signed_over = 1 DESC LIMIT 1";
777+
let query =
778+
"SELECT block_info FROM blocks WHERE consensus_hash = ? AND signed_over = 1 LIMIT 1";
778779
let result: Option<String> = query_row(&self.db, query, [tenure])?;
779780

780781
Ok(result.is_some())
@@ -1971,13 +1972,21 @@ mod tests {
19711972
assert!(db.has_signed_block_in_tenure(&consensus_hash_1).unwrap());
19721973
assert!(!db.has_signed_block_in_tenure(&consensus_hash_2).unwrap());
19731974

1975+
block_info.block.header.consensus_hash = consensus_hash_2;
19741976
block_info.block.header.chain_length = 2;
19751977
block_info.signed_over = false;
19761978

19771979
db.insert_block(&block_info).unwrap();
19781980

19791981
assert!(db.has_signed_block_in_tenure(&consensus_hash_1).unwrap());
19801982
assert!(!db.has_signed_block_in_tenure(&consensus_hash_2).unwrap());
1983+
1984+
block_info.signed_over = true;
1985+
1986+
db.insert_block(&block_info).unwrap();
1987+
1988+
assert!(db.has_signed_block_in_tenure(&consensus_hash_1).unwrap());
1989+
assert!(db.has_signed_block_in_tenure(&consensus_hash_2).unwrap());
19811990
}
19821991

19831992
#[test]

0 commit comments

Comments
 (0)