Merge pull request #6357 from csgui/update-wasm-develop

update clarity-wasm-develop branch

Author: csgui

.cargo/config.toml

@@ -1,7 +1,8 @@
 [alias]
 stacks-node = "run --package stacks-node --"
 fmt-stacks = "fmt -- --config group_imports=StdExternalCrate,imports_granularity=Module"
-clippy-stacks = "clippy -p libstackerdb -p stacks-signer -p pox-locking -p clarity -p libsigner -p stacks-common --no-deps --tests --all-features -- -D warnings"
+clippy-stacks = "clippy -p stx-genesis -p libstackerdb -p stacks-signer -p pox-locking -p clarity-serialization -p clarity -p libsigner -p stacks-common --no-deps --tests --all-features -- -D warnings"
+clippy-stackslib = "clippy -p stackslib --no-deps -- -Aclippy::all -Wclippy::indexing_slicing"
 
 # Uncomment to improve performance slightly, at the cost of portability
 #   * Note that native binaries may not run on CPUs that are different from the build machine

.github/actions/bitcoin-int-tests/Dockerfile.atlas-test

@@ -14,6 +14,6 @@ RUN cd / && tar -xvzf bitcoin-25.0-x86_64-linux-gnu.tar.gz
 RUN ln -s /bitcoin-25.0/bin/bitcoind /bin/
 
 ENV BITCOIND_TEST 1
-WORKDIR /src/testnet/stacks-node
+WORKDIR /src/stacks-node
 RUN cargo test -- --test-threads 1 --ignored tests::neon_integrations::atlas_integration_test
 RUN cargo test -- --test-threads 1 --ignored tests::neon_integrations::atlas_stress_integration_test

.github/actions/bitcoin-int-tests/Dockerfile.generic.bitcoin-tests

@@ -4,7 +4,7 @@ WORKDIR /src/
 
 COPY . .
 
-WORKDIR /src/testnet/stacks-node
+WORKDIR /src/stacks-node
 
 RUN rustup component add llvm-tools-preview && \
     cargo install grcov

.github/actions/bitcoin-int-tests/Dockerfile.large-genesis

@@ -22,7 +22,7 @@ RUN cargo test --no-run --workspace && \
     cargo build --workspace
 
 ENV BITCOIND_TEST 1
-RUN cd testnet/stacks-node && cargo test --release --features prod-genesis-chainstate -- --test-threads 1 --ignored neon_integrations::bitcoind_integration_test
+RUN cd stacks-node && cargo test --release --features prod-genesis-chainstate -- --test-threads 1 --ignored neon_integrations::bitcoind_integration_test
 
 RUN grcov . --binary-path ./target/debug/ -s . -t lcov --branch --ignore-not-existing --ignore "/*" -o lcov.info
 

.github/actions/dockerfiles/Dockerfile.alpine-binary

@@ -31,7 +31,7 @@ RUN case "${TAG}" in \
             ;; \
         *) \
             echo "/bin/stacks-node mainnet" > /tmp/command.sh && \
-            rm /bin/blockstack-cli /bin/clarity-cli /bin/relay-server /bin/stacks-events /bin/stacks-inspect \
+            rm /bin/blockstack-cli /bin/clarity-cli /bin/stacks-events /bin/stacks-inspect \
             ;; \
     esac && \
     chmod +x /tmp/command.sh

.github/actions/dockerfiles/Dockerfile.debian-binary

@@ -31,7 +31,7 @@ RUN case "${TAG}" in \
             ;; \
         *) \
             echo "/bin/stacks-node mainnet" > /tmp/command.sh && \
-            rm /bin/blockstack-cli /bin/clarity-cli /bin/relay-server /bin/stacks-events /bin/stacks-inspect \
+            rm /bin/blockstack-cli /bin/clarity-cli /bin/stacks-events /bin/stacks-inspect \
             ;; \
     esac && \
     chmod +x /tmp/command.sh

.github/workflows/cargo-hack-check.yml

@@ -0,0 +1,118 @@
+name: Cargo Hack Check
+
+on:
+  workflow_call:
+
+env:
+  RUST_BACKTRACE: full
+
+concurrency:
+  group: cargo-hack-check-${{ github.head_ref || github.ref || github.run_id }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+  # Setup job to prepare common dependencies
+  setup:
+    name: Setup
+    runs-on: ubuntu-latest
+    outputs:
+      rust-toolchain: ${{ steps.toolchain.outputs.rust-toolchain }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          persist-credentials: false
+
+      - name: Get Rust toolchain
+        id: toolchain
+        run: echo "rust-toolchain=$(cat ./rust-toolchain)" >> $GITHUB_OUTPUT
+
+  # Native targets (Windows/Linux)
+  native-targets:
+    name: All Crates (Windows/Linux)
+    runs-on: ubuntu-latest
+    needs: setup
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          persist-credentials: false
+
+      - name: Setup Rust with Cache
+        uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
+        with:
+          toolchain: ${{ needs.setup.outputs.rust-toolchain }}
+          target: x86_64-pc-windows-gnu,x86_64-unknown-linux-gnu
+          cache: true
+          cache-key: cargo-hack-native-${{ needs.setup.outputs.rust-toolchain }}-${{ hashFiles('**/Cargo.lock') }}
+
+      - name: Install cargo-hack
+        uses: taiki-e/install-action@2383334cf567d78771fc7d89b6b3802ef1412cf6  # v2.56.8
+        with:
+          tool: cargo-hack
+
+      - name: Install Windows cross-compilation tools
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y gcc-mingw-w64-x86-64
+
+      - name: Run cargo hack check
+        run: |
+          cargo hack check \
+            --all \
+            --each-feature \
+            --no-dev-deps \
+            --exclude-features=wasm-deterministic,wasm-web \
+            --target x86_64-pc-windows-gnu \
+            --target x86_64-unknown-linux-gnu
+
+  # WASM targets - separate cache since dependencies differ
+  wasm-targets:
+    name: ${{ matrix.name }}
+    runs-on: ubuntu-latest
+    needs: setup
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: "Clarity & Stacks-Common WASM Web"
+            command: |
+              cargo hack check \
+                -p clarity-serialization \
+                -p stacks-common \
+                --each-feature \
+                --no-dev-deps \
+                --exclude-features=default,rusqlite,ctrlc-handler,wasm-deterministic \
+                --features=wasm-web
+
+          - name: "Clarity & Stacks-Common WASM Deterministic"
+            command: |
+              cargo hack check \
+                -p clarity-serialization \
+                -p stacks-common \
+                --each-feature \
+                --no-dev-deps \
+                --include-features=wasm-deterministic,slog_json \
+                --features=wasm-deterministic
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          persist-credentials: false
+
+      - name: Setup Rust with Cache
+        uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
+        with:
+          toolchain: ${{ needs.setup.outputs.rust-toolchain }}
+          target: wasm32-unknown-unknown
+          cache: true
+          cache-key: cargo-hack-wasm-${{ matrix.name }}-${{ needs.setup.outputs.rust-toolchain }}-${{ hashFiles('**/Cargo.lock') }}
+
+      - name: Install cargo-hack
+        uses: taiki-e/install-action@2383334cf567d78771fc7d89b6b3802ef1412cf6 # v2.56.8
+        with:
+          tool: cargo-hack
+
+      - name: Run cargo hack check
+        run: ${{ matrix.command }}

.github/workflows/ci.yml

@@ -19,7 +19,6 @@ on:
       - opened
       - reopened
       - synchronize
-      - ready_for_review
 
 defaults:
   run:
@@ -94,6 +93,7 @@ jobs:
     needs:
       - rustfmt
       - check-release
+    secrets: inherit
     uses: ./.github/workflows/github-release.yml
     with:
       node_tag: ${{ needs.check-release.outputs.node_tag }}
@@ -145,6 +145,27 @@ jobs:
       - check-release
     uses: ./.github/workflows/stacks-core-tests.yml
 
+  ## Validate constants dumped by stacks-inspect
+  ##
+  ## Runs when:
+  ##   - it is a node or signer-only release run
+  ##   or any of:
+  ##     - this workflow is called manually
+  ##     - PR is opened
+  ##     - PR added to merge queue
+  constants-check:
+    if: |
+      needs.check-release.outputs.is_node_release == 'true' ||
+      needs.check-release.outputs.is_signer_release == 'true' ||
+      github.event_name == 'workflow_dispatch' ||
+      github.event_name == 'pull_request' ||
+      github.event_name == 'merge_group'
+    name: Constants Check
+    needs:
+      - rustfmt
+      - check-release
+    uses: ./.github/workflows/constants-check.yml
+
   ## Checks to run on built binaries
   ##
   ## Runs when:
@@ -153,18 +174,18 @@ jobs:
   ##     - this workflow is called manually
   ##     - PR is opened
   ##     - PR added to merge queue
-  stacks-core-build-tests:
+  cargo-hack-check:
     if: |
       needs.check-release.outputs.is_node_release == 'true' ||
       needs.check-release.outputs.is_signer_release == 'true' ||
       github.event_name == 'workflow_dispatch' ||
       github.event_name == 'pull_request' ||
       github.event_name == 'merge_group'
-    name: Stacks Core Build Tests
+    name: Cargo Hack Check
     needs:
       - rustfmt
       - check-release
-    uses: ./.github/workflows/core-build-tests.yml
+    uses: ./.github/workflows/cargo-hack-check.yml
 
   ## Checks to run on built binaries
   ##

.github/workflows/clarity-js-sdk-pr.yml

@@ -1,4 +1,4 @@
-name: Core build tests
+name: Constants Check
 
 # Only run when:
 #   - PRs are (re)opened against develop branch
@@ -9,6 +9,10 @@ jobs:
   check-consts:
     name: Check the constants from stacks-inspect
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash
+
     steps:
       - name: Checkout the latest code
         id: git_checkout
@@ -21,13 +25,14 @@ jobs:
         uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}
-      - name: Build the binaries
-        id: build
-        run: |
-          cargo build
+
       - name: Dump constants JSON
         id: consts-dump
-        run: cargo run --bin stacks-inspect -- dump-consts | tee out.json
-      - name: Set expected constants JSON
+        run: |
+          cargo run --bin stacks-inspect -- dump-consts | tee out.json
+
+      ## output any diff to the github job summary
+      - name: Compare expected constants JSON
         id: expects-json
-        run: diff out.json ./sample/expected_consts.json
+        run: |
+          diff out.json ./sample/expected_consts.json >> $GITHUB_STEP_SUMMARY