Do not allow token transfers and filter out phantom txs from parse_transactions fn

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jferrant

testnet/stacks-node/src/tests/nakamoto_integrations.rs

@@ -241,7 +241,7 @@ impl TestSigningChannel {
 
 /// Assert that the block events captured by the test observer
 ///  all match the miner heuristic of *exclusively* including the
-///  tenure change transaction and token transfers in tenure changing blocks.
+///  tenure change transaction in tenure changing blocks.
 pub fn check_nakamoto_empty_block_heuristics() {
     let blocks = test_observer::get_blocks();
     for block in blocks.iter() {
@@ -257,12 +257,10 @@ pub fn check_nakamoto_empty_block_heuristics() {
             let only_coinbase_and_tenure_change = txs.iter().all(|tx| {
                 matches!(
                     tx.payload,
-                    TransactionPayload::TenureChange(_)
-                        | TransactionPayload::Coinbase(..)
-                        | TransactionPayload::TokenTransfer(..)
+                    TransactionPayload::TenureChange(_) | TransactionPayload::Coinbase(..)
                 )
             });
-            assert!(only_coinbase_and_tenure_change, "Nakamoto blocks with a tenure change in them should only have coinbase, tenure changes, or token transfers.");
+            assert!(only_coinbase_and_tenure_change, "Nakamoto blocks with a tenure change in them should only have coinbase or tenure changes");
         }
     }
 }

testnet/stacks-node/src/tests/neon_integrations.rs

@@ -194,9 +194,10 @@ pub mod test_observer {
     use std::sync::Mutex;
     use std::thread;
 
+    use clarity::boot_util::boot_code_addr;
     use stacks::chainstate::stacks::boot::RewardSet;
     use stacks::chainstate::stacks::events::StackerDBChunksEvent;
-    use stacks::chainstate::stacks::StacksTransaction;
+    use stacks::chainstate::stacks::{StacksTransaction, TransactionPayload};
     use stacks::codec::StacksMessageCodec;
     use stacks::config::{EventKeyType, EventObserverConfig};
     use stacks::net::api::postblock_proposal::BlockValidateResponse;
@@ -578,7 +579,7 @@ pub mod test_observer {
         PROPOSAL_RESPONSES.lock().unwrap().clear();
     }
 
-    /// Parse the StacksTransactions from a block (does not include burn ops)
+    /// Parse the StacksTransactions from a block (does not include burn ops or phantom txs)
     ///  panics on any failures to parse
     pub fn parse_transactions(block: &serde_json::Value) -> Vec<StacksTransaction> {
         block
@@ -597,6 +598,14 @@ pub mod test_observer {
                 let tx_bytes = hex_bytes(&tx_hex[2..]).unwrap();
                 let tx =
                     StacksTransaction::consensus_deserialize(&mut tx_bytes.as_slice()).unwrap();
+
+                let mainnet_address = boot_code_addr(true).into();
+                let testnet_address = boot_code_addr(false).into();
+                if let TransactionPayload::TokenTransfer(address, amount, _) = &tx.payload {
+                    if *address == mainnet_address || *address == testnet_address && *amount == 0 {
+                        return None;
+                    }
+                }
                 Some(tx)
             })
             .collect()