Merge pull request #6311 from stacks-network/develop

Develop

Author: wileyj

.cargo/config.toml

@@ -1,7 +1,7 @@
 [alias]
 stacks-node = "run --package stacks-node --"
 fmt-stacks = "fmt -- --config group_imports=StdExternalCrate,imports_granularity=Module"
-clippy-stacks = "clippy -p stx-genesis -p libstackerdb -p stacks-signer -p pox-locking -p clarity -p libsigner -p stacks-common --no-deps --tests --all-features -- -D warnings -A clippy::uninlined-format-args"
+clippy-stacks = "clippy -p stx-genesis -p libstackerdb -p stacks-signer -p pox-locking -p clarity -p libsigner -p stacks-common --no-deps --tests --all-features -- -D warnings"
 clippy-stackslib = "clippy -p stackslib --no-deps -- -Aclippy::all -Wclippy::indexing_slicing"
 
 # Uncomment to improve performance slightly, at the cost of portability

.github/workflows/nix-check.yml

@@ -0,0 +1,41 @@
+name: Check Nix
+
+on:
+  merge_group:
+    types:
+      - checks_requested
+  push:
+    branches:
+      - master
+      - develop
+      - next
+    paths-ignore:
+      - "**.md"
+      - "**.yml"
+  workflow_dispatch:
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - synchronize
+
+concurrency:
+  group: nix-${{ github.head_ref || github.ref || github.run_id }}
+  ## Always cancel duplicate jobs
+  cancel-in-progress: true
+
+run-name: ${{ github.ref_name }}
+
+permissions: {}
+
+jobs:
+  build-pkg:
+    name: Check Nix package
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: DeterminateSystems/determinate-nix-action@d4b23d0b9eeeaeba3648c24d43bcb623dcf75336 # v3.7.0
+      - uses: DeterminateSystems/magic-nix-cache-action@e1c1dae8e170ed20fd2e6aaf9979ca2d3905d636  # v12
+        with:
+          use-flakehub: false  # Remove error when trying to authenticate without credentials
+      - run: nix flake check ./contrib/nix

.github/workflows/stacks-core-tests.yml

@@ -61,12 +61,15 @@ jobs:
     name: OpenAPI Validation
     runs-on: ubuntu-latest
     steps:
-      - name: OpenAPI
+      - name: Generate OpenAPI documentation
         id: openapi
         uses: stacks-network/actions/openapi@main
         with:
-          input: ./docs/rpc/openapi.yaml
-          output: ./open-api-docs.html
+          input: "./docs/rpc/openapi.yaml"
+          output: "./openapi-docs.html"
+          config: "./docs/rpc/redocly.yaml"
+          validate: "true"
+          redocly-version: "1.34"
 
   ## Disabled
   ##   - this test can take several hours to run

CHANGELOG.md

@@ -7,11 +7,20 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE
 
 ## Unreleased
 
-- The HTTP `Date` header in responses now strictly follows RFC7231.
+### Added
+
+- Added `/v3/contracts/fast-call-read/:principal/:contract_name/:func_name` api endpoint. It allows to run read-only calls faster by disabling the cost and memory trackers. This endpoint requires authentication.
 
 ### Changed
 
+- The HTTP `Date` header in responses now strictly follows RFC7231.
 - When a previous block commit is unable to be RBFed, the miner will now just wait for it to be confirmed instead of submitting a new block commit which breaks the miner's UTXO chain.
+- When mining, only log new block proposal responses, not duplicates.
+
+### Fixed
+
+- Fixed tenure downloader logic on reward cycle boundaries (#6234).
+- Do not send events to event observers for stale StackerDB chunks.
 
 ## [3.1.0.0.13]
 

Cargo.lock

@@ -14,24 +14,29 @@ members = [
 
 # Dependencies we want to keep the same between workspace members
 [workspace.dependencies]
-ed25519-dalek = { version = "2.1.1", features = ["serde", "rand_core"] }
+ed25519-dalek = { version = "2.1.1", default-features = false }
 hashbrown = { version = "0.15.2", features = ["serde"] }
+lazy_static = "1.4.0"
 rand_core = "0.6.4"
 rand = "0.8"
 rand_chacha = "0.3.1"
-tikv-jemallocator = "0.5.4"
+serde = "1"
+serde_derive = "1"
+serde_json = { version = "1.0", features = ["arbitrary_precision", "unbounded_depth"] }
+slog = { version = "2.5.2", features = [ "max_level_trace" ] }
 rusqlite = { version = "0.31.0", features = ["blob", "serde_json", "i128_blob", "bundled", "trace"] }
+tikv-jemallocator = "0.5.4"
 thiserror = "1.0.65"
 toml = "0.5.6"
 
 # Use a bit more than default optimization for
-#  dev builds to speed up test execution
+# dev builds to speed up test execution
 [profile.dev]
 opt-level = 1
 
 # Use release-level optimization for dependencies
 # This slows down "first" builds on development environments,
-#  but won't impact subsequent builds.
+# but won't impact subsequent builds.
 [profile.dev.package."*"]
 opt-level = 3
 

Cargo.toml

@@ -18,8 +18,6 @@ name = "clarity"
 path = "./src/libclarity.rs"
 
 [dependencies]
-rand = { workspace = true }
-rand_chacha = { workspace = true }
 serde = "1"
 serde_derive = "1"
 serde_stacker = "0.1"
@@ -28,8 +26,8 @@ lazy_static = "1.4.0"
 integer-sqrt = "0.1.3"
 slog = { version = "2.5.2", features = [ "max_level_trace" ] }
 stacks_common = { package = "stacks-common", path = "../stacks-common", default-features = false }
-rstest = "0.17.0"
-rstest_reuse = "0.5.0"
+rstest = { version = "0.17.0", optional = true }
+rstest_reuse = { version = "0.5.0", optional = true }
 hashbrown = { workspace = true }
 rusqlite = { workspace = true, optional = true }
 
@@ -40,6 +38,8 @@ features = ["arbitrary_precision", "unbounded_depth"]
 [dev-dependencies]
 assert-json-diff = "1.0.0"
 mutants = "0.0.3"
+rstest = { version = "0.17.0" }
+rstest_reuse = { version = "0.5.0" }
 # a nightly rustc regression (35dbef235 2021-03-02) prevents criterion from compiling
 #  but it isn't necessary for tests: only benchmarks. therefore, commenting out for now.
 # criterion = "0.3"
@@ -49,7 +49,8 @@ default = ["rusqlite"]
 developer-mode = ["stacks_common/developer-mode"]
 slog_json = ["stacks_common/slog_json"]
 rusqlite = ["stacks_common/rusqlite", "dep:rusqlite"]
-testing = []
+testing = ["rstest", "rstest_reuse"]
 devtools = []
 rollback_value_check = []
 disable-costs = []
+wasm-web = ["stacks_common/wasm-web"]

clarity/Cargo.toml

@@ -58,7 +58,7 @@ impl std::error::Error for Error {
 
 impl std::fmt::Display for Error {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(f, "{:?}", self)
+        write!(f, "{self:?}")
     }
 }
 

clarity/src/vm/analysis/arithmetic_checker/mod.rs

@@ -77,8 +77,7 @@ fn test_bad_defines(#[case] version: ClarityVersion, #[case] epoch: StacksEpochI
         assert_eq!(
             arithmetic_check(contract, version, epoch),
             Err(error.clone()),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
     }
 }
@@ -120,14 +119,12 @@ fn test_variables_fail_arithmetic_check_clarity1() {
         assert_eq!(
             arithmetic_check(contract, ClarityVersion::Clarity1, StacksEpochId::Epoch2_05),
             result.clone(),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
         assert_eq!(
             arithmetic_check(contract, ClarityVersion::Clarity1, StacksEpochId::Epoch21),
             result.clone(),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
     }
 
@@ -188,8 +185,7 @@ fn test_variables_fail_arithmetic_check_clarity2() {
         assert_eq!(
             arithmetic_check(contract, ClarityVersion::Clarity2, StacksEpochId::Epoch21),
             result.clone(),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
     }
 }
@@ -321,14 +317,12 @@ fn test_functions_clarity1() {
         assert_eq!(
             arithmetic_check(contract, ClarityVersion::Clarity1, StacksEpochId::Epoch2_05),
             result.clone(),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
         assert_eq!(
             arithmetic_check(contract, ClarityVersion::Clarity1, StacksEpochId::Epoch21),
             result.clone(),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
     }
 }
@@ -458,8 +452,7 @@ fn test_functions_clarity2() {
         assert_eq!(
             arithmetic_check(contract, ClarityVersion::Clarity2, StacksEpochId::Epoch21),
             result.clone(),
-            "Check contract:\n {}",
-            contract
+            "Check contract:\n {contract}"
         );
     }
 }