chore: address review comments

Author: obycode

testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs

@@ -1721,7 +1721,7 @@ impl BitcoinRegtestController {
                         &addr2str(&addr),
                         epoch_id
                     );
-                    return Err(BurnchainControllerError::NoUtxos);
+                    return Err(BurnchainControllerError::NoUTXOs);
                 }
             };
             utxos
@@ -1941,7 +1941,7 @@ impl BitcoinRegtestController {
             })
             .map_err(|e| {
                 error!("Bitcoin RPC error: transaction submission failed - {:?}", e);
-                BurnchainControllerError::TransactionSubmissionFailed
+                BurnchainControllerError::TransactionSubmissionFailed(format!("{:?}", e))
             })
     }
 

testnet/stacks-node/src/burnchains/mod.rs

@@ -22,8 +22,8 @@ pub enum Error {
     BurnchainError,
     MaxFeeRateExceeded,
     IdenticalOperation,
-    NoUtxos,
-    TransactionSubmissionFailed,
+    NoUTXOs,
+    TransactionSubmissionFailed(String),
     SerializerError,
 }
 
@@ -35,8 +35,10 @@ impl fmt::Display for Error {
             Error::BurnchainError => write!(f, "Burnchain error"),
             Error::MaxFeeRateExceeded => write!(f, "Max fee rate exceeded"),
             Error::IdenticalOperation => write!(f, "Identical operation, not submitting"),
-            Error::NoUtxos => write!(f, "No UTXOs available"),
-            Error::TransactionSubmissionFailed => write!(f, "Transaction submission failed"),
+            Error::NoUTXOs => write!(f, "No UTXOs available"),
+            Error::TransactionSubmissionFailed(e) => {
+                write!(f, "Transaction submission failed: {e}")
+            }
             Error::SerializerError => write!(f, "Serializer error"),
         }
     }

testnet/stacks-node/src/nakamoto_node.rs

@@ -33,6 +33,7 @@ use stacks_common::types::StacksEpochId;
 
 use super::{Config, EventDispatcher, Keychain};
 use crate::burnchains::bitcoin_regtest_controller::addr2str;
+use crate::burnchains::Error as BurnchainsError;
 use crate::neon_node::{LeaderKeyRegistrationState, StacksNode as NeonNode};
 use crate::run_loop::boot_nakamoto::Neon2NakaData;
 use crate::run_loop::nakamoto::{Globals, RunLoop};
@@ -93,7 +94,7 @@ pub enum Error {
     /// Something unexpected happened (e.g., hash mismatches)
     UnexpectedChainState,
     /// A burnchain operation failed when submitting it to the burnchain
-    BurnchainSubmissionFailed,
+    BurnchainSubmissionFailed(BurnchainsError),
     /// A new parent has been discovered since mining started
     NewParentDiscovered,
     /// A failure occurred while constructing a VRF Proof

testnet/stacks-node/src/nakamoto_node/relayer.rs

@@ -1050,7 +1050,7 @@ impl RelayerThread {
             )
             .map_err(|e| {
                 warn!("Failed to submit block-commit bitcoin transaction: {}", e);
-                NakamotoNodeError::BurnchainSubmissionFailed
+                NakamotoNodeError::BurnchainSubmissionFailed(e)
             })?;
 
         info!(