more restful path for blockbyheight

Author: rdeioris

stackslib/src/net/api/getblockbyheight.rs

@@ -61,11 +61,11 @@ impl HttpRequest for RPCNakamotoBlockByHeightRequestHandler {
     }
 
     fn path_regex(&self) -> Regex {
-        Regex::new(r#"^/v3/blockbyheight/(?P<block_height>[0-9]{1,20})$"#).unwrap()
+        Regex::new(r#"^/v3/blocks/height/(?P<block_height>[0-9]{1,20})$"#).unwrap()
     }
 
     fn metrics_identifier(&self) -> &str {
-        "/v3/blockbyheight/:block_height"
+        "/v3/blocks/height/:block_height"
     }
 
     /// Try to decode this request.
@@ -212,7 +212,7 @@ impl StacksHttpRequest {
         StacksHttpRequest::new_for_peer(
             host,
             "GET".into(),
-            format!("/v3/blockbyheight/{}", block_height),
+            format!("/v3/blocks/height/{}", block_height),
             HttpRequestContents::new().for_tip(tip),
         )
         .expect("FATAL: failed to construct request from infallible data")

testnet/stacks-node/src/tests/nakamoto_integrations.rs

@@ -9426,7 +9426,7 @@ fn v3_blockbyhash_api_endpoint() {
     run_loop_thread.join().unwrap();
 }
 
-/// Test `/v3/blockbyheight` API endpoint
+/// Test `/v3/blocks/height` API endpoint
 ///
 /// This endpoint returns the block blob given a height
 #[test]
@@ -9519,7 +9519,7 @@ fn v3_blockbyheight_api_endpoint() {
     let http_origin = format!("http://{}", &conf.node.rpc_bind);
 
     let get_v3_block_by_height = |height: u64| {
-        let url = &format!("{http_origin}/v3/blockbyheight/{height}");
+        let url = &format!("{http_origin}/v3/blocks/height/{height}");
         info!("Send request: GET {url}");
         reqwest::blocking::get(url).unwrap_or_else(|e| panic!("GET request failed: {e}"))
     };