chore: last cleanup from p2p::conv test movement

Author: kantai

stackslib/src/net/chat.rs

@@ -510,7 +510,7 @@ impl Neighbor {
             }
         };
 
-        #[cfg(any(test, feature = "testing"))]
+        #[cfg(test)]
         {
             // setting BLOCKSTACK_NEIGHBOR_TEST_${PORTNUMBER} will let us select an organization
             // for this peer
@@ -3060,7 +3060,6 @@ impl ConversationP2P {
 
 #[cfg(test)]
 mod test {
-    #![allow(unused)]
     use std::fs;
     use std::io::prelude::*;
     use std::io::{Read, Write};

stackslib/src/net/neighbors/mod.rs

@@ -42,9 +42,9 @@ pub use db::{NeighborReplacements, NeighborWalkDB, PeerDBNeighborWalk};
 pub use walk::{NeighborPingback, NeighborWalk, NeighborWalkResult};
 
 /// How often we can contact other neighbors, at a minimim
-#[cfg(any(test, feature = "testing"))]
+#[cfg(test)]
 pub const NEIGHBOR_MINIMUM_CONTACT_INTERVAL: u64 = 0;
-#[cfg(not(any(test, feature = "testing")))]
+#[cfg(not(test))]
 pub const NEIGHBOR_MINIMUM_CONTACT_INTERVAL: u64 = 600;
 
 /// Default number of seconds to wait for a reply from a neighbor