docs: Add /v3/signer/

Author: jbencin

CHANGELOG.md

@@ -16,6 +16,7 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE
     - `get-stacks-block-info?` added
     - `get-tenure-info?` added
     - `get-block-info?` removed
+- Added `/v3/signer/` endpoint
 
 ## [2.5.0.0.5]
 

docs/rpc-endpoints.md

@@ -533,3 +533,8 @@ highest sortition), `reward_cycle` identifies the reward cycle number of this
 tenure, `tip_block_id` identifies the highest-known block in this tenure, and
 `tip_height` identifies that block's height.
 
+### GET /v3/signer/[Signer Pubkey]/[Reward Cycle]
+
+Get number of blocks signed by signer during a given reward cycle
+
+Returns a non-negative integer

docs/rpc/openapi.yaml

@@ -675,3 +675,33 @@ paths:
         schema:
           type: string
 
+  /v3/signer/{signer}/{cycle_number}:
+    get:
+      summary: Get number of blocks signed by signer during a given reward cycle
+      tags:
+        - Blocks
+        - Signers
+      operationId: get_signer
+      description: Get number of blocks signed by signer during a given reward cycle
+      parameters:
+        - name: signer
+          in: path
+          required: true
+          description: Hex-encoded compressed Secp256k1 public key of signer
+          schema:
+            type: string
+      parameters:
+        - name: cycle_number
+          in: path
+          required: true
+          description: Reward cycle number
+          schema:
+            type: integer
+      responses:
+        200:
+          description: Number of blocks signed
+          content:
+            text/plain:
+              schema:
+                type: integer
+                example: 7

stackslib/src/chainstate/nakamoto/mod.rs

@@ -3300,7 +3300,7 @@ impl NakamotoChainState {
         chainstate_db: &Connection,
         signer_pubkey: &Secp256k1PublicKey,
         reward_cycle: u64,
-    ) -> Result<Option<u64>, ChainstateError> {
+    ) -> Result<u64, ChainstateError> {
         let sql =
             "SELECT blocks_signed FROM signer_stats WHERE public_key = ?1 AND reward_cycle = ?2";
         let params = params![serde_json::to_string(&signer_pubkey).unwrap(), reward_cycle];
@@ -3316,6 +3316,7 @@ impl NakamotoChainState {
                 })
             })
             .optional()
+            .map(Option::unwrap_or_default) // It's fine to map `NONE` to `0`, because it's impossible to have `Some(0)`
             .map_err(ChainstateError::from)
     }